-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default setting for autoInstrumentation.requestHandler as true can truncate MDX output in Astro #9985
Comments
This is also in the astro/vite watch dev server, I have not been able to try a built version yet. |
I have a suspicion that we are somehow truncating the response stream here: sentry-javascript/packages/astro/src/server/middleware.ts Lines 162 to 171 in ea74266
Superficially looking at it I don't see anything immediately wrong. I also have yet to reproduce I would have one thing I would want to try which would affect non-strictly-utf8-encoded streams: #9989 Maybe you could try an isolated reproduction with non-utf8-encoded files? I will have @Lms24 take a more educated look next week! |
We shipped the change mentioned by Luca in https://github.com/getsentry/sentry-javascript/releases/tag/7.92.0 - please give it a try! |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/browser
SDK Version
7.91.0
Framework Version
Astro 4.0.7
Link to Sentry event
No response
SDK Setup
Steps to Reproduce
I am unable to reproduce this issue in isolation and I am seeking further debugging steps.
In my project when I have
autoInstrumentation.requestHandler
set totrue
(either as above, or by not specifyingautoInstrumentation
at all and letting the default value take effect) mdx pages are truncated. Short pages are blank, and long pages have the end cut off.This does not happen with md or astro pages, only mdx.
Expected Result
The following screenshots are from the end of a long mdx page when
autoInstrumentation.requestHandler
is set tofalse
:Actual Result
These screenshots are from the end of that same long mdx page when
autoInstrumentation.requestHandler
is set totrue
(or unspecified):The text was updated successfully, but these errors were encountered: