Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(astro): reduce unnecessary path resolutions #10021

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Jan 2, 2024

  • No need to call process.cwd() on every iteration.
  • No need to create paths on memory

@anonrig anonrig requested review from a team, AbhiPrasad and ale-cota and removed request for a team January 2, 2024 20:15
Copy link
Contributor

github-actions bot commented Jan 2, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.94 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.3 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.93 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.88 KB (+0.06% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (0%)
@sentry/browser - Webpack (gzipped) 22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.34 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.01 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.16 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.16 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 203.92 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 93.81 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.73 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.12 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.71 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.35 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.99 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (0%)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anonrig anonrig merged commit e1da7d3 into develop Jan 2, 2024
32 of 33 checks passed
@anonrig anonrig deleted the perf-astro-extensions branch January 2, 2024 22:32
anonrig added a commit that referenced this pull request Jan 3, 2024
- No need to call `process.cwd()` on every iteration.
- No need to create paths on memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants