feat(core): Deprecate span.toTraceparent() in favor of spanToTraceHeader() util
#10031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Jan 3, 2024
| @@ -16,7 +17,7 @@ function traceHeaders(this: Hub): { [key: string]: string } { | |||
|
|
|||
| return span | |||
| ? { | |||
| 'sentry-trace': span.toTraceparent(), | |||
| 'sentry-trace': spanToTraceHeader(span), | |||
There was a problem hiding this comment.
(no action required)
TIL about this function. Not sure why it exists - my guess is downstream SDKs (maybe RN/Electron)...
mydea
force-pushed
the
fn/spanToTraceparent
branch
3 times, most recently
from
e1d1b87 to
f5c228e
Compare
Instead, there is a new util `spanToTraceHeader(span)` which can be used. This is done to align the Span schema with OpenTelemetry. Open question: Do we need to re-export this from all our packages?
mydea
force-pushed
the
fn/spanToTraceparent
branch
from
f5c228e to
4471aa4
Compare
anonrig
pushed a commit
that referenced
this pull request
Jan 3, 2024
…Header()` util (#10031) Instead, there is a new util `spanToTraceHeader(span)` which can be used. This is done to align the Span schema with OpenTelemetry. Open question: Do we need to re-export this from all our packages, so users can also use this directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, there is a new util
spanToTraceHeader(span)which can be used. This is done to align the Span schema with OpenTelemetry.Open question: Do we need to re-export this from all our packages, so users can also use this directly?