Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): handle commonjs related issues #10042

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix(astro): handle commonjs related issues #10042

merged 1 commit into from
Jan 4, 2024

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Jan 3, 2024

Fixes #10040

@anonrig anonrig requested review from a team, AbhiPrasad and ale-cota and removed request for a team January 3, 2024 16:15
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm interesting, I'm surprised if this fixed the issue tbh because we always thought us requiring https-proxy-agent was a more fundamental problem for none-node environments. I'm fine with the fix, since we're guarding it by the astro CF adapter for now. Let's see if we actually get this working all the way. Thanks for fixing!

@anonrig
Copy link
Contributor Author

anonrig commented Jan 3, 2024

hmm interesting, I'm surprised if this fixed the issue tbh because we always thought us requiring https-proxy-agent was a more fundamental problem for none-node enironments. I'm fine with the fix, since we're guarding it by the astro CF adapter for now. Let's see if we actually get this working all the way. Thanks for fixing!

@Lms24 For reference, http://astro-rewrite.yagiz.pages.dev now uses Sentry on both server-side and frontend side.

@Lms24
Copy link
Member

Lms24 commented Jan 3, 2024

Amazing!

@anonrig anonrig enabled auto-merge (squash) January 4, 2024 08:38
@anonrig anonrig merged commit 3acb7e4 into develop Jan 4, 2024
32 of 33 checks passed
@anonrig anonrig deleted the fix-astro-ssr branch January 4, 2024 08:40
@F0rce
Copy link

F0rce commented Jan 4, 2024

Is there an ETA on when this PR and for example #9994 will be released? I just came across this error yesterday (using the astro cloudflare adapter) and was super happy to see that all the relevant PR's already have been merged.

@Lms24
Copy link
Member

Lms24 commented Jan 4, 2024

@F0rce Probably still this week/next week Monday the latest.

@F0rce
Copy link

F0rce commented Jan 4, 2024

@Lms24 wow thanks for the super fast reply. Then I'll just wait for the release :) tyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpsProxyAgent breaks Astro
4 participants