-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(astro): handle commonjs related issues #10042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm interesting, I'm surprised if this fixed the issue tbh because we always thought us requiring https-proxy-agent was a more fundamental problem for none-node environments. I'm fine with the fix, since we're guarding it by the astro CF adapter for now. Let's see if we actually get this working all the way. Thanks for fixing!
@Lms24 For reference, http://astro-rewrite.yagiz.pages.dev now uses Sentry on both server-side and frontend side. |
Amazing! |
Is there an ETA on when this PR and for example #9994 will be released? I just came across this error yesterday (using the astro cloudflare adapter) and was super happy to see that all the relevant PR's already have been merged. |
@F0rce Probably still this week/next week Monday the latest. |
@Lms24 wow thanks for the super fast reply. Then I'll just wait for the release :) tyy |
Fixes #10040