Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node): otel Express integration tests #10169

Merged
merged 5 commits into from
Jan 16, 2024
Merged

test(node): otel Express integration tests #10169

merged 5 commits into from
Jan 16, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 12, 2024 •
edited
Loading

  • Adds CJS integration tests for express for @sentry/node-experimental
  • Converts all the existing express tests to use the new runner
    • These are the only tests that dont appear to like the jest runner in their original form
  • Added a cleanupChildProcesses() method to the runner than should be called in the afterAll hook to ensure no processes are left open/leaked

I haven't managed to get otel ESM express auto instrumentation to work yet...

timfish and others added 2 commits January 15, 2024 11:52
@timfish timfish marked this pull request as ready for review January 15, 2024 11:49
@AbhiPrasad AbhiPrasad merged commit daef9a7 into getsentry:develop Jan 16, 2024
40 checks passed
@timfish timfish deleted the test/node-express branch January 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timfish @mydea @AbhiPrasad