Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Jan 25, 2024

Temporarily hot-fixes the type definitions in the node package by re-exporting all of the types that typescript reaches into the package. We should sustainably fix this by not packing in the build folder.

Also introduces a gh check that checks for these faulty files. While we have this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.93 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.68 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.07 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.26 KB (-0.01% 🔽)
@sentry/browser - Webpack (gzipped) 22.5 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.57 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.13 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.97 KB (-0.09% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.43 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.42 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.44 KB (-0.17% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.08 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.07 KB (-0.09% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.44 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.11 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.4 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@lforst lforst enabled auto-merge (squash) January 25, 2024 11:21
@lforst lforst merged commit 18a342f into develop Jan 25, 2024
@lforst lforst deleted the lforst-hotfix-types branch January 25, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants