-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): Add wrapHandleErrorWithSentry
#10370
Conversation
size-limit report 📦
|
9e73ddf
to
8d064ef
Compare
@@ -105,6 +105,26 @@ export function wrapRemixHandleError(err: unknown, { request }: DataFunctionArgs | |||
}); | |||
} | |||
|
|||
// To be deprecated in favor of `sentryHandleError` | |||
export const wrapRemixHandleError = sentryHandleError; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a deprecated js doc to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also realized if we are deprecating we need to add to MIGRATION.md
2b2377d
to
d1eb044
Compare
c613f9c
to
8687723
Compare
MIGRATION.md
Outdated
This release deprecates `wrapRemixHandleError` in favor of using `sentryHandleError` from `@sentry/remix`. It can be | ||
used as below: | ||
|
||
````typescript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
````typescript | |
```typescript |
MIGRATION.md
Outdated
@@ -324,7 +337,7 @@ typescript: | |||
|
|||
```ts | |||
const replay = getClient().getIntegrationByName<Replay>('Replay'); | |||
``` | |||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub doesn't allow me to auto suggest this, but this should be ``` instead of ```` (3 instead of 4)
022dae4
to
e7149f2
Compare
e7149f2
to
b32c098
Compare
b32c098
to
818d411
Compare
818d411
to
96d0f36
Compare
Bundle ReportChanges will decrease total bundle size by 3.42MB ⬇️
|
96d0f36
to
58cd216
Compare
58cd216
to
96ceab7
Compare
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
96ceab7
to
34f57f5
Compare
Closes: #10212
Sentry.wrapHandleErrorWithSentry
for customhandleError
implementations.handleError
implementation, then runs the Sentry's capture logic.wrapRemixHandleError
tosentryHandleError
, to avoid confusion. We're still exportingwrapRemixHandleError
as alias.