Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Enforce masking of credit card fields #10472

Merged
merged 1 commit into from
Feb 2, 2024
Merged

feat(replay): Enforce masking of credit card fields #10472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"dependencies": {
"@babel/preset-typescript": "^7.16.7",
"@playwright/test": "^1.40.1",
"@sentry-internal/rrweb": "2.10.0",
"@sentry-internal/rrweb": "2.11.0",
"@sentry/browser": "7.99.0",
"@sentry/tracing": "7.99.0",
"axios": "1.6.0",
Expand Down
1 change: 1 addition & 0 deletions dev-packages/browser-integration-tests/suites/replay/privacyInput/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<textarea id="textarea"></textarea>
<textarea id="textarea-masked" data-sentry-mask></textarea>
<textarea id="textarea-ignore" data-sentry-ignore></textarea>
<input data-sentry-unmask autocomplete="cc-number" id="should-still-be-masked" />

<input type="submit" value="Submit form" />
<input data-sentry-unmask type="submit" value="Unmasked button" />
Expand Down
18 changes: 18 additions & 0 deletions dev-packages/browser-integration-tests/suites/replay/privacyInput/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,18 @@ sentryTest(
// This one should not have any input mutations
return inputMutationSegmentIds.length === 2 && inputMutationSegmentIds[1] < event.segment_id;
});
const reqPromise4 = waitForReplayRequest(page, (event, res) => {
const check =
inputMutationSegmentIds.length === 2 &&
inputMutationSegmentIds[1] < event.segment_id &&
getIncrementalRecordingSnapshots(res).some(isInputMutation);

if (check) {
inputMutationSegmentIds.push(event.segment_id);
}

return check;
});

await page.route('https://dsn.ingest.sentry.io/**/*', route => {
return route.fulfill({
Expand Down Expand Up @@ -160,5 +172,11 @@ sentryTest(
await forceFlushReplay();
const snapshots3 = getIncrementalRecordingSnapshots(await reqPromise3).filter(isInputMutation);
expect(snapshots3.length).toBe(0);

await page.locator('#should-still-be-masked').fill(text);
await forceFlushReplay();
const snapshots4 = getIncrementalRecordingSnapshots(await reqPromise4).filter(isInputMutation);
const lastSnapshot4 = snapshots4[snapshots4.length - 1];
expect(lastSnapshot4.data.text).toBe('*'.repeat(text.length));
},
);
2 changes: 1 addition & 1 deletion packages/replay-canvas/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"homepage": "https://docs.sentry.io/platforms/javascript/session-replay/",
"devDependencies": {
"@babel/core": "^7.17.5",
"@sentry-internal/rrweb": "2.10.0"
"@sentry-internal/rrweb": "2.11.0"
},
"dependencies": {
"@sentry/core": "7.99.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/replay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"devDependencies": {
"@babel/core": "^7.17.5",
"@sentry-internal/replay-worker": "7.99.0",
"@sentry-internal/rrweb": "2.10.0",
"@sentry-internal/rrweb-snapshot": "2.10.0",
"@sentry-internal/rrweb": "2.11.0",
"@sentry-internal/rrweb-snapshot": "2.11.0",
"fflate": "^0.8.1",
"jsdom-worker": "^0.2.1"
},
Expand Down
52 changes: 22 additions & 30 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5416,33 +5416,33 @@
semver "7.3.2"
semver-intersect "1.4.0"

"@sentry-internal/rrdom@2.10.0":
version "2.10.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrdom/-/rrdom-2.10.0.tgz#7f86667939a100bee2f82b6d459e275855ccc583"
integrity sha512-28G4W8BCdqI8GsO1SYkCBIwuizLwHrg8gE4u77v0zKpiaeIyZjYJ0QqhA/gMrTHLqrfI+FAwGXchnamjci45BA==
"@sentry-internal/rrdom@2.11.0":
version "2.11.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrdom/-/rrdom-2.11.0.tgz#f7c8f54705ad84ece0e97e53f12e87c687749b32"
integrity sha512-BZnkTrbLm9Y3R70W1+8TnImys0RbKsgyB70WQoFdUervGvPw1kLcWJOJrPcDWgVe7nlbG+bEWb6iQrvLqldycw==
dependencies:
"@sentry-internal/rrweb-snapshot" "2.10.0"
"@sentry-internal/rrweb-snapshot" "2.11.0"

"@sentry-internal/rrweb-snapshot@2.10.0":
version "2.10.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-2.10.0.tgz#fa894fad3110fa8b912e41eb328bd956581c0ac0"
integrity sha512-/bqbmCzEn8o/hki9Jrng6xIkjczYlPHTEv+C/NDT7Q8A7WJ9KqIpCkljqyoNrD2o9OtwFuPAVgKyIPRkZF9ZfA==
"@sentry-internal/rrweb-snapshot@2.11.0":
version "2.11.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-2.11.0.tgz#1af79130604afea989d325465b209ac015b27c9a"
integrity sha512-1nP22QlplMNooSNvTh+L30NSZ+E3UcfaJyxXSMLxUjQHTGPyM1VkndxZMmxlKhyR5X+rLbxi/+RvuAcpM43VoA==

"@sentry-internal/rrweb-types@2.10.0":
version "2.10.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-types/-/rrweb-types-2.10.0.tgz#d9da0362c31c4e96b8649bbc9ab8bb380051caf3"
integrity sha512-nnwRrH0O8J+OsOEK3LeVruTv6JovZWEFywdacyfNt2LK7XTCG8182lU6bzPK3Ganb9ps2eOkJqOTRMYUZ1TrMA==
"@sentry-internal/rrweb-types@2.11.0":
version "2.11.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-types/-/rrweb-types-2.11.0.tgz#e598c133b87be1fb04d31d09773b86142b095072"
integrity sha512-foCf9DGfN5ffzwykEtIXsV1P5d+XLDVGaQUnKF5ecGn+g5JzKTe/rPC92rL8/gEy2unL5sCTvlYL3DQvUFM4dA==
dependencies:
"@sentry-internal/rrweb-snapshot" "2.10.0"
"@sentry-internal/rrweb-snapshot" "2.11.0"

"@sentry-internal/rrweb@2.10.0":
version "2.10.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-2.10.0.tgz#a101f08f4b5de70145dbbdf70e7d2a0ac4d0d83e"
integrity sha512-S2xC0xxliCCgfowFImqIK6i9dfaEuTsLrzYkPxxX54OjqjrTsJw41aGxGfYPh+PP6nWMiURuOM5jRZrbvxoH4A==
"@sentry-internal/rrweb@2.11.0":
version "2.11.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-2.11.0.tgz#be8e8dfff2acf64d418b625d35a20fdcd7daeb96"
integrity sha512-QuEqpKmRDb0xQe9fhJ3j/JHO6uxFMWBowADJBA4rvVU5HbExIg9gor1tZ0b3gDuChXnnx7pxFj9/QXZjQQ75zg==
dependencies:
"@sentry-internal/rrdom" "2.10.0"
"@sentry-internal/rrweb-snapshot" "2.10.0"
"@sentry-internal/rrweb-types" "2.10.0"
"@sentry-internal/rrdom" "2.11.0"
"@sentry-internal/rrweb-snapshot" "2.11.0"
"@sentry-internal/rrweb-types" "2.11.0"
"@types/css-font-loading-module" "0.0.7"
"@xstate/fsm" "^1.4.0"
base64-arraybuffer "^1.0.1"
Expand Down Expand Up @@ -5560,15 +5560,6 @@
"@sentry/types" "7.93.0"
"@sentry/utils" "7.93.0"

"@sentry/hub@7.93.0":
version "7.93.0"
resolved "https://registry.yarnpkg.com/@sentry/hub/-/hub-7.93.0.tgz#3db26f74dc1269650fa9ec553f0837af5caa0d30"
integrity sha512-gfPyT3DFGYYM5d+CHiS0YJHkIJHa8MKSfl32RkCMA5KQr9RF0H+GR5LZCinQOWq43fpsncSLyuoMfBjgbMLN+w==
dependencies:
"@sentry/core" "7.93.0"
"@sentry/types" "7.93.0"
"@sentry/utils" "7.93.0"

"@sentry/node@7.93.0":
version "7.93.0"
resolved "https://registry.yarnpkg.com/@sentry/node/-/node-7.93.0.tgz#7786d05d1e3e984207a866b07df1bf891355892e"
Expand Down Expand Up @@ -12196,6 +12187,7 @@ cron@^3.1.6:
dependencies:
"@types/luxon" "~3.3.0"
luxon "~3.4.0"

cross-env@^7.0.3:
version "7.0.3"
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
Expand Down
Loading