Skip to content

feat(opentelemetry): Support forceTransaction in OTEL #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat(opentelemetry): Support forceTransaction in OTEL #10807

merged 1 commit into from
Feb 28, 2024

Conversation

@mydea
Copy link
Member

@mydea mydea commented Feb 26, 2024 •
edited
Loading

This implements forceTransaction for otel/node.

@mydea mydea self-assigned this Feb 26, 2024
@mydea mydea mentioned this pull request Feb 26, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.27 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.54 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.45 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.08 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.7 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.7 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.91 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 30.91 KB (0%)
@sentry/browser - Webpack (gzipped) 22.18 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.39 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.17 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.72 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.72 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.92 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.26 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.79 KB (0%)
@sentry/react - Webpack (gzipped) 22.19 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.23 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.57 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@mydea mydea force-pushed the fn/startSpan-transaction branch from 569def4 to 8bfa2b1 Compare February 26, 2024 11:54
@mydea mydea force-pushed the fn/forceTranscationOtel branch from 135e613 to dbb8669 Compare February 26, 2024 11:54
Base automatically changed from fn/startSpan-transaction to develop February 26, 2024 12:13
mydea added a commit that referenced this pull request Feb 26, 2024
@mydea
feat(core): Allow to pass forceTransaction to startSpan() APIs (#…
372e405 
…10749)

This will ensure a span is sent as a transaction to Sentry.

This only implements this option for the core implementation, not yet
for OTEL - that is a follow up here:
#10807
mydea added a commit that referenced this pull request Feb 27, 2024
@mydea
feat(core): Allow to pass forceTransaction to startSpan() APIs (b…
f533ed8 
…ackport)

This will ensure a span is sent as a transaction to Sentry.

This only implements this option for the core implementation, not yet
for OTEL - that is a follow up here:
#10807

fixes...
@mydea mydea mentioned this pull request Feb 27, 2024
Merged
mydea added a commit that referenced this pull request Feb 27, 2024
@mydea
feat(core): Allow to pass forceTransaction to startSpan() APIs (b…
a10187d 
…ackport) (#10819)

This will ensure a span is sent as a transaction to Sentry.

This only implements this option for the core implementation, not yet
for OTEL - that is a follow up here:
#10807

This is a backport to v7 of
#10749
@mydea mydea force-pushed the fn/forceTranscationOtel branch from dbb8669 to 282c5fb Compare February 27, 2024 15:12
@mydea mydea marked this pull request as ready for review February 27, 2024 15:12
@mydea mydea requested review from AbhiPrasad, Lms24 and lforst February 27, 2024 15:12
@mydea
Copy link
Member Author

mydea commented Feb 27, 2024

Depends on #10806 being merged first...

@mydea mydea force-pushed the fn/forceTranscationOtel branch from 282c5fb to 214493f Compare February 27, 2024 16:38
@mydea mydea force-pushed the fn/forceTranscationOtel branch from 214493f to b163791 Compare February 28, 2024 08:36
@mydea mydea merged commit 2187b99 into develop Feb 28, 2024
@mydea mydea deleted the fn/forceTranscationOtel branch February 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea @AbhiPrasad