-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ignore ResizeObserver and undefined error #10845
Conversation
type: 'Error', | ||
value: 'undefined', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is a scary change, in JS you never know.
But how useful can an undefined error be?
Reason I added it is because, apparently, not all ResizeObserver
has a value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that the undefined
event is related to ResizeObserver
? It might just have gotten grouped together accidentally 🤔
My concern about undefined
if we're not sure is just that there could be cases where the error message is undefined (for whatever reason) but there might be a stack trace attached, making the issue more debuggable again. Suggestion: We split this PR up so we can more easily revert the undefined
filter if necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - I leave undefined
away for now.
size-limit report 📦
|
We want to filter out
ResizeObserver
error since they are not actionable and have no stacktrace and break transaction status. ref https://stackoverflow.com/a/77680580/1139707Also, I added to filter out undefined errors - here are two events to Sentry to represent this.
undefined:
https://sentry.sentry.io/issues/3611187513/events/46ed8c398c234ff89baee87c5c341844/
ResizeObserver:
https://sentry.sentry.io/issues/3611187513/events/48f25ea9dfbf4bd0b84a18982ee73362/