feat(node): Allow to configure skipOpenTelemetrySetup
#10907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Mar 4, 2024
mydea
force-pushed
the
fn/allow-custom-provider
branch
3 times, most recently
from
d2dc5ab to
1bb501f
Compare
Also warn if there is an incomplete setup, to ensure users notice if stuff is breaking.
mydea
force-pushed
the
fn/allow-custom-provider
branch
from
1bb501f to
2fa83c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also warn if there is an incomplete setup, to ensure users notice if stuff is breaking.
I do this by just keeping a set of things that were created, which is not perfect but IMHO good enough to notify users if they forgot to setup a specific thing...