Skip to content

feat(v8/profiling-node): Use OTEL powered node package #11033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat(v8/profiling-node): Use OTEL powered node package #11033

wants to merge 3 commits into from

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 11, 2024

ref #9956

Switch from relying on @sentry/node-experimental to @sentry/node.

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and mydea and removed request for a team March 11, 2024 18:56
@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Mar 11, 2024

Ah this is troublesome because of

[!] (plugin sucrase) SyntaxError: Error transforming /home/runner/work/sentry-javascript/sentry-javascript/node_modules/require-in-the-middle/package.json: Unexpected token, expected ";" (2:9)
../../node_modules/require-in-the-middle/package.json (2:9)
SyntaxError: Error transforming /home/runner/work/sentry-javascript/sentry-javascript/node_modules/require-in-the-middle/package.json: Unexpected token, expected ";" (2:9)
    at unexpected (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/util.js:99:15)
    at semicolon (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/util.js:77:5)
    at parseStatementContent (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:251:21)
    at parseStatement (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:116:3)
    at parseBlockBody (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:586:5)
    at parseBlock (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:575:3)
    at parseStatementContent (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:185:7)
    at parseStatement (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:116:3)
    at parseBlockBody (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:586:5)
    at parseTopLevel (/home/runner/work/sentry-javascript/sentry-javascript/node_modules/sucrase/dist/parser/traverser/statement.js:92:3)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

We have to set all the OTEL stuff as external for this package.

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Mar 12, 2024

actually @timfish do you know why Sucrase is attempting to transform package.json here?

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Mar 12, 2024

blocked by #11052

@AbhiPrasad AbhiPrasad self-assigned this Mar 13, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 13, 2024
Closed
@AbhiPrasad AbhiPrasad force-pushed the abhi-profiling-node-with-otel branch from c992112 to 56404a9 Compare March 13, 2024 02:40
@mydea mydea force-pushed the abhi-profiling-node-with-otel branch from a693262 to 924d740 Compare March 13, 2024 09:11
@AbhiPrasad AbhiPrasad marked this pull request as draft March 13, 2024 21:05
@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Mar 13, 2024

Moving to draft - this requires a rollup upgrade for some rollup commonjs plugin fixes

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Mar 15, 2024

Superceded by #11135

@AbhiPrasad AbhiPrasad closed this Mar 15, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-profiling-node-with-otel branch March 15, 2024 15:25
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 22, 2024
Merged
AbhiPrasad added a commit that referenced this pull request Mar 25, 2024
@AbhiPrasad
feat(profiling): Use OTEL powered node package (#11239)
4291bce 
ref #9956

This is another attempt at
#11033 now that
#11135 has merged in.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(profiling): Use OTEL powered node package (getsentry#11239)
2972ae9 
ref getsentry#9956

This is another attempt at
getsentry#11033 now that
getsentry#11135 has merged in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea Awaiting requested review from mydea

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-javascript-sdks

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad