feat(v8/angular): Merge angular and angular-ivy packages and start Angular support at v14 #11091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
force-pushed
the
sig-remove-angular-ivy
branch
from
0f6b33f to
d9a6ad3
Compare
size-limit report 📦
|
s1gr1d
changed the title
s1gr1d
force-pushed
the
sig-remove-angular-ivy
branch
from
ad0886f to
6c36876
Compare
Lms24
reviewed
Mar 18, 2024
s1gr1d
force-pushed
the
sig-remove-angular-ivy
branch
2 times, most recently
from
6de10d1 to
b67eeb5
Compare
s1gr1d
force-pushed
the
sig-remove-angular-ivy
branch
from
b67eeb5 to
2199c11
Compare
3 tasks
Lms24
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
I tested this PR in
- A simple NG17 test app ✅
- A simple NG14 test app ✅
- My personal side project running on NG14 ✅
- In the reproduction app of #9448 which appears to fix the issue ✅
As expected (but still good that it's confirmed), the SDK now no longer works in a simple NG13 app, meaning 14 will be the definitive lower bound for v8. I think this is perfectly acceptable.
Let's merge this - great work!
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…gular support at v14 (getsentry#11091) Start using vitest for better ESM support (since Angular 13) closes getsentry#9830 --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using vitest for better ESM support (since Angular 13)
closes #9830