Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browsertracing/inp): Ensure interactionIdToRouteNameMapping[id] is defined before destructuring #11157

Closed
wants to merge 2 commits into from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 18, 2024

Quick fix for #11156 but I'm not sure how we run into the error in the first place. @edwardgou-sentry would you mind taking a look? Happy to close my PR for a better fix :)

ref #11156

@Lms24 Lms24 changed the base branch from develop to v7 March 18, 2024 10:27
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 79.95 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.07 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.04 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 64.7 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.02 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 34.9 KB (-0.01% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.44 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.45 KB (0%)
@sentry/browser - Webpack (gzipped) 22.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.18 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.57 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.34 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.09 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 106.9 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.38 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 38.62 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.53 KB (0%)
@sentry/react - Webpack (gzipped) 22.71 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.35 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 53.51 KB (-0.01% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.28 KB (0%)

Copy link
Contributor

@edwardgou-sentry edwardgou-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lms24 ! lgtm, I'll take a look to see why its undefined in the first place

@edwardgou-sentry edwardgou-sentry dismissed their stale review March 18, 2024 14:48

Different fix in mind

@edwardgou-sentry
Copy link
Contributor

Hey @Lms24 , I thought about this a little bit and I think I know why the mapping is returning undefined. I'll put up a pr that will handle this scenario better, sorry for the inconvenience! Feel free to close this pr!

@Lms24
Copy link
Member Author

Lms24 commented Mar 18, 2024

Thanks @edwardgou-sentry no worries, as I said, I'm happy to close this in favor of a better fix :)

@Lms24 Lms24 closed this Mar 18, 2024
@AbhiPrasad AbhiPrasad deleted the lms/fix-browsertracing-inp-error branch March 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants