Skip to content

fix(metrics): use correct statsd data category #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(metrics): use correct statsd data category #11184

merged 1 commit into from
Mar 19, 2024

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad requested a review from a team March 18, 2024 21:22
@AbhiPrasad AbhiPrasad self-assigned this Mar 18, 2024
@AbhiPrasad AbhiPrasad requested review from Lms24 and mydea and removed request for a team March 18, 2024 21:22
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 18, 2024
Closed
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.74 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.1 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.9 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.66 KB (added)
@sentry/browser (incl. Tracing) 36.7 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.7 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.36 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.48 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.49 KB (added)
@sentry/browser (incl. sendFeedback) 27.45 KB (added)
@sentry/browser 22.62 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.08 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.92 KB (added)
CDN Bundle (incl. Tracing) 36.28 KB (added)
CDN Bundle 23.99 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.62 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.56 KB (added)
CDN Bundle - uncompressed 71.09 KB (added)
@sentry/react (incl. Tracing, Replay) 72.09 KB (added)
@sentry/react 22.64 KB (added)

@AbhiPrasad AbhiPrasad mentioned this pull request Mar 18, 2024
Merged
@AbhiPrasad
Copy link
Member Author

After this PR gets merged in we can look at #10945

AbhiPrasad added a commit that referenced this pull request Mar 19, 2024
@AbhiPrasad
fix(metrics): use correct statsd data category (#11187)
17a0e0f 
As per
https://github.com/getsentry/relay/blob/2f49cfeb4ed44068e4556ac6ad234f35ee3fde88/relay-server/src/envelope.rs#L166C30-L166C36

Backport for #11184
@AbhiPrasad AbhiPrasad merged commit 34643e3 into develop Mar 19, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-metrics-fix-data-category branch March 19, 2024 13:27
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
fix(metrics): use correct statsd data category (getsentry#11184)
7794d65 
As per
https://github.com/getsentry/relay/blob/2f49cfeb4ed44068e4556ac6ad234f35ee3fde88/relay-server/src/envelope.rs#L166C30-L166C36

Will backport to v7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-javascript-sdks

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad @Lms24