feat(node): Ensure tracePropagationTargets are respected
#11285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 26, 2024
mydea
force-pushed
the
fn/node-propagation
branch
from
7ca0cb4 to
c9fe753
Compare
mydea
force-pushed
the
fn/node-propagation
branch
from
c9fe753 to
b2ea066
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…#11285) This PR ensures that `tracePropagationTargets` are respected for node API requests. I also updated the node-fetch instrumentation, because that fixed an issue where `http.url` was not correctly set. I also updated the other node-fastify E2E tests to be less flaky (we could have race conditions of transactions we were waiting for). I bumped `@types/node` to the correct version to ensure I can use `crypto` properly in tests (and that generally makes sense, I'd say). Closes getsentry#11272
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
With this change, there are two remaining references to node-experimental. 1. nextjs, which is handled by getsentry#11016 2. express integration tests, which I will address after getsentry#11285 gets merged Once those two are done, we can remove the old node packages entirely!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
tracePropagationTargetsare respected for node API requests.I also updated the node-fetch instrumentation, because that fixed an issue where
http.urlwas not correctly set.I also updated the other node-fastify E2E tests to be less flaky (we could have race conditions of transactions we were waiting for). I bumped
@types/nodeto the correct version to ensure I can usecryptoproperly in tests (and that generally makes sense, I'd say).Closes #11272