ref(core): Remove transaction name extraction from requestDataIntegration
#11513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
size-limit report 📦
|
Lms24
changed the title
added 2 commits
April 24, 2024 14:49
…ansactionName-from-requestDataIntegration
lforst
changed the title
requestDataIntegration
mydea
reviewed
Apr 25, 2024
| return { | ||
| name: INTEGRATION_NAME, | ||
| processEvent(event, _hint, client) { | ||
| processEvent(event, _hint, _client) { |
There was a problem hiding this comment.
Suggested change
| processEvent(event, _hint, _client) { | |
| processEvent(event) { |
mydea
reviewed
Apr 25, 2024
| }; | ||
| } | ||
|
|
||
| function getSDKName(client: Client): string | undefined { |
There was a problem hiding this comment.
Why did we even do this before here 😅 but I guess it is just not needed because we always set this directly now, right?
mydea
approved these changes
Apr 25, 2024
lforst
deleted the
lms/feat-remove-transactionName-from-requestDataIntegration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed two places where we assign
event.transactionlet's see how badly this nukes CI 👀