feat(core): Deprecate addTracingExtensions
#11579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, users should use `registerSpanErrorInstrumentation` which is now does much less things than before.
mydea
changed the title
addTracingExtensionsaddTracingExtensions
size-limit report 📦
|
Lms24
approved these changes
Apr 12, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Instead, users can use `registerSpanErrorInstrumentation` which is now does much less things than before. I opted to not fully remove this yet because I guess the chance that somebody may have been using this is somewhat high, and we can easily continue to have it with no bundle size hit for those who don't need it. We also couldn't really deprecate this in v7 so I think it's OK to leave this in for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, users can use
registerSpanErrorInstrumentationwhich is now does much less things than before.I opted to not fully remove this yet because I guess the chance that somebody may have been using this is somewhat high, and we can easily continue to have it with no bundle size hit for those who don't need it. We also couldn't really deprecate this in v7 so I think it's OK to leave this in for now.