Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Re-enable OTEL fetch instrumentation and disable Next.js fetch instrumentation #11686

Merged
merged 12 commits into from
Apr 19, 2024
Merged

fix(nextjs): Re-enable OTEL fetch instrumentation and disable Next.js fetch instrumentation #11686

merged 12 commits into from
Apr 19, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 18, 2024 •
edited
Loading

Re-enables the otel fetch instrumentation since Next.js' one doesn't propagate. Also disables Next.js' own fetch instrumentation so we don't get double spans.

Also, adds tests for trace propagation in Next.js and fixes up some tests.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (0%)
@sentry/browser (incl. Tracing) 31.4 KB (0%)
@sentry/browser (incl. Tracing, Replay) 66.73 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.14 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.57 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.44 KB (0%)
@sentry/browser (incl. Feedback) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.28 KB (0%)
@sentry/browser (incl. sendFeedback) 26.46 KB (0%)
@sentry/react 24.35 KB (0%)
@sentry/react (incl. Tracing) 34.31 KB (0%)
@sentry/vue 25.2 KB (0%)
@sentry/vue (incl. Tracing) 33.12 KB (0%)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 24.03 KB (0%)
CDN Bundle (incl. Tracing) 32.71 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.37 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.57 KB (0%)
CDN Bundle - uncompressed 70.85 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 97.5 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.16 KB (0%)
@sentry/nextjs (client) 33.64 KB (0%)
@sentry/sveltekit (client) 31.9 KB (0%)
@sentry/node 160.37 KB (+2.78% 🔺)

@lforst lforst changed the title feat(nextjs): Propagate traces test(nextjs): Add E2E tests for trace propagation in Next.js Apr 19, 2024
@lforst lforst requested a review from mydea April 19, 2024 08:35
@lforst lforst changed the base branch from develop to fn/next-http April 19, 2024 08:36
@lforst lforst changed the base branch from fn/next-http to develop April 19, 2024 08:36
@lforst lforst marked this pull request as ready for review April 19, 2024 08:36
@lforst lforst changed the title test(nextjs): Add E2E tests for trace propagation in Next.js fix(nextjs): Re-enable OTEL fetch instrumentation and disable Next.js fetch instrumentation Apr 19, 2024
mydea
mydea approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find! 🚀

@lforst lforst merged commit 3a45a3c into develop Apr 19, 2024
67 checks passed
@lforst lforst deleted the lforst-trace-propagation-in-nextjs branch April 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @mydea