Skip to content

Conversation

AbhiPrasad
Copy link
Member

Based on feedback from @timfish in #11667 (comment) - update the addOpenTelemetryInstrumentation API to use rest args.

@AbhiPrasad AbhiPrasad requested review from mydea and timfish April 22, 2024 13:59
@AbhiPrasad AbhiPrasad self-assigned this Apr 22, 2024
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) April 22, 2024 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.63 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.97 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.37 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.02 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.21 KB (0%)
@sentry/browser (incl. Feedback) 37.76 KB (0%)
@sentry/browser (incl. sendFeedback) 26.43 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.91 KB (0%)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.53 KB (0%)
@sentry/vue 25.26 KB (0%)
@sentry/vue (incl. Tracing) 34.38 KB (0%)
@sentry/svelte 21.77 KB (0%)
CDN Bundle 23.95 KB (0%)
CDN Bundle (incl. Tracing) 33.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 83.44 KB (0%)
CDN Bundle - uncompressed 70.56 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 100.57 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.18 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.49 KB (0%)
@sentry/nextjs (client) 34.75 KB (0%)
@sentry/sveltekit (client) 33.13 KB (0%)
@sentry/node 152.84 KB (+0.01% 🔺)

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Apr 22, 2024

I feel like sisyphus trying to merge this PR in

@AbhiPrasad AbhiPrasad merged commit 0a440dd into develop Apr 23, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-otel-instrumentation-args branch April 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants