Skip to content

ref(svelte): Use onlyIfParent for recording component update spans #11809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2024
Merged

ref(svelte): Use onlyIfParent for recording component update spans #11809

merged 2 commits into from
Apr 26, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 26, 2024 •
edited
Loading

Small refactor; The previous guard also worked but using onlyIfParent instead of checking for getActiveSpan saves us a couple of bytes

@Lms24 Lms24 requested review from a team, AbhiPrasad and mydea and removed request for a team April 26, 2024 11:52
@Lms24 Lms24 merged commit eb35e54 into develop Apr 26, 2024
@Lms24 Lms24 deleted the lms/ref-svelte-componentTracking-onlyIfParent branch April 26, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad AbhiPrasad was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24 @mydea