Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): Use consistent timestamps #12063

Merged
merged 1 commit into from
May 16, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 16, 2024

In some places we used Date.now(), instead of timestampInSeconds() which used performance.now().

There are still other places where we use Date.now(), esp. in replay and node, but I focused on regular browser stuff for now (because this is most likely to be affected by this).

In some places we used `Date.now()`, instead of `timestampInSeconds()` which used performance.now().
@mydea mydea requested review from Lms24, s1gr1d and andreiborza May 16, 2024 08:00
@mydea mydea self-assigned this May 16, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (added)
@sentry/browser (incl. Tracing) 32.72 KB (added)
@sentry/browser (incl. Tracing, Replay) 68.06 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.47 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.1 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.11 KB (added)
@sentry/browser (incl. Feedback) 37.61 KB (added)
@sentry/browser (incl. sendFeedback) 26.23 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.61 KB (added)
@sentry/react 24.36 KB (added)
@sentry/react (incl. Tracing) 35.68 KB (added)
@sentry/vue 25.51 KB (added)
@sentry/vue (incl. Tracing) 34.51 KB (added)
@sentry/svelte 21.8 KB (added)
CDN Bundle 24.21 KB (added)
CDN Bundle (incl. Tracing) 34.14 KB (added)
CDN Bundle (incl. Tracing, Replay) 67.83 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.79 KB (added)
CDN Bundle - uncompressed 71.2 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 101.24 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.86 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.16 KB (added)
@sentry/nextjs (client) 34.92 KB (added)
@sentry/sveltekit (client) 33.28 KB (added)
@sentry/node 140.99 KB (added)
@sentry/aws-serverless 128.03 KB (added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants