- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.7k
 
fix(node): Ensure fetch/http breadcrumbs are created correctly #12137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
          size-limit report 📦
  | 
    
| 
           This should also be added to the   | 
    
          
 Did that! And actually noticed this was fundamentally flawed, and tied to the http.client spans - so it was not working at all without performance 😬 so I adjusted all of this for fetch and http to ensure we always get breadcrumbs, and added tests for this.  | 
    
8bcf4e3    to
    012ca89      
    Compare
  
    012ca89    to
    a5558ec      
    Compare
  
    
This PR ensures that (node) fetch and http requests generate breadcrumbs correctly, even if tracing is disabled.
It also adds tests for this, and ensures we pass the request/response to the hint correctly.
Fixes #12132