ref(node): Only show instrumentation warning when tracing is enabled #12141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
force-pushed
the
ab/warn-instrumentation-only-when-tracing-enabled
branch
from
cd1e4c7 to
2855d9b
Compare
mydea
reviewed
May 21, 2024
| @@ -48,12 +50,19 @@ export const setupConnectErrorHandler = (app: ConnectApp): void => { | |||
| }); | |||
| } | |||
|
|
|||
| if (!isWrapped(app.use) && isEnabled()) { | |||
| if (!isWrapped(app.use) && isEnabled() && hasTracingEnabled()) { | |||
There was a problem hiding this comment.
Could we maybe extract this into a utility and re-use this? Could be something like this:
function ensureIsWrapped(maybeWrappedModule: unknown, name: string): void {
if (!isWrapped(maybeWrappedModule) && isEnabled() && hasTracingEnabled()) {
// ...
}
}There was a problem hiding this comment.
Extracted, could you please have another look 🙏
mydea
changed the title
andreiborza
force-pushed
the
ab/warn-instrumentation-only-when-tracing-enabled
branch
from
b1b8402 to
e123f24
Compare
andreiborza
force-pushed
the
ab/warn-instrumentation-only-when-tracing-enabled
branch
from
e123f24 to
239817f
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also gives a better warning in ESM mode with a helpful link to the docs.