ci: Add optional E2E tests for sending to Sentry #12259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/optional-e2e-test
branch
from
cdb6966 to
c974252
Compare
mydea
force-pushed
the
fn/optional-e2e-test
branch
from
a1891c4 to
53985f6
Compare
mydea
changed the title
mydea
changed the title
size-limit report 📦
|
AbhiPrasad
approved these changes
May 28, 2024
| timeout: 5000, | ||
| }, | ||
| /* Run tests in files in parallel */ | ||
| fullyParallel: true, |
There was a problem hiding this comment.
Feel like we should unify these configs in a future PR.
There was a problem hiding this comment.
Yeah, I'll look into this in some follow up!
mydea
force-pushed
the
fn/optional-e2e-test
branch
from
26644c4 to
e05ca08
Compare
mydea
added a commit
that referenced
this pull request
May 29, 2024
Instead of just testing to send to Sentry, this now tests the actual payloads being sent. This kind of builds on top of #12259, where we specifically test the event sending now.
Lms24
added a commit
that referenced
this pull request
Jul 8, 2024
Enable running E2E tests on PRs opened from forked repositories. Previously we excluded these because some E2E tests required secrets which are not available in the forks, causing e2e test runs to always fail. Now that we separated these tests from the e2e tests that don't require secrets (#12259) we should be good to re-enable the required e2e tests for external PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new E2E test
react-send-to-sentrythat is run optionally.For now this is the same as the old
standard-frontend-reacttest - eventually we can/should update that test (and others) to stop sending to sentry.This test will run in a separate group that we do not block merging on when it fails.
For now, there is one browser and one node test that checks that they send events successfully to Sentry - IMHO that should cover stuff decently for now. I also made the source maps debug ID test optional, as that inherently sends to Sentry.
We can in follow ups get rid of all the event sending stuff from the remaining E2E tests.
Part of #11910