feat: Add thirdPartyErrorFilterIntegration
#12267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, another issue here is that |
size-limit report 📦
|
timfish
commented
May 31, 2024
| | 'drop-error-if-exclusively-contains-third-party-frames' | ||
| | 'apply-tag-if-contains-third-party-frames' | ||
| | 'apply-tag-if-exclusively-contains-third-party-frames'; | ||
| } |
There was a problem hiding this comment.
These are much better names!
There was a problem hiding this comment.
Yup, I agree. Your comment was a wake-up call 😂
andreiborza
approved these changes
Jun 6, 2024
| }), | ||
| } as unknown as Client; | ||
|
|
||
| describe('ThirdPartyErrorFilter', () => { |
There was a problem hiding this comment.
l: these tests lend themselves well to parameterization
There was a problem hiding this comment.
True, but it's a bit annoying since we are checking for defined-ness and that is not so easy to do in parameterized tests.
There was a problem hiding this comment.
Do you mean expect(result).toBeDefined();? I think using expect.anything() should work for that.
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
3 tasks
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described here:
#11718 (comment)
I didn't want to use the word
integritysince for me at least, it reminds me of Subresource Integrity hashes and this is nothing like that. It's more of anid. For the metadata property I usedbundle_keyalthough it might be a better idea to use something that is less likely to clash with users existing metadata like__bundler_key.My only minor concern is the behaviour strings which use what feels like a double negative logic... drop-if-not-matched. It made it quite hard to reason about what each one did and I got the logic wrong myself a couple of times!