Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add Gitlab CI support in getSentryRelease #12507

Closed
wants to merge 1 commit into from
Closed

feat(node): Add Gitlab CI support in getSentryRelease #12507

wants to merge 1 commit into from

Conversation

MarcEspiard
Copy link

Adds support for Gitlab CI/CD in getSentryRelease function

@AbhiPrasad AbhiPrasad mentioned this pull request Jun 17, 2024
Closed
@AbhiPrasad
Copy link
Member

Hey! thanks for the PR :)

We'll merge this in soon - let me update https://github.com/getsentry/sentry-javascript-bundler-plugins/ first!

@AbhiPrasad AbhiPrasad self-requested a review June 17, 2024 15:04
@AbhiPrasad AbhiPrasad self-assigned this Jun 17, 2024
@AbhiPrasad
Copy link
Member

Looking at codecov there seems to be more environmental variables that are Gitlab specific! https://github.com/codecov/codecov-cli/blob/24d49dd4a4e879687218faf97cfc6f5b9d83a413/codecov_cli/helpers/ci_adapters/gitlab_ci.py#L14-L16

@MarcEspiard
Copy link
Author

Hey, I only added the commit sha to stay consistent with the rest of the values for the other providers.
I'm pretty sure the commit sha is always there but happy to update with the additional values if needed.
Would we follow the same order as codecov or put the commit sha first and fallback to the other 2?

@MarcEspiard
Copy link
Author

Just saw you opened a PR for a lot more providers and you won't need this, thanks for taking care of this so fast :)

@AbhiPrasad
Copy link
Member

@MarcEspiard I will prob open a new PR and sort out the ordering, I'll just cherry-pick your commit to you get the contribution creds.

Thanks again for the PR, it's a good reminder for us to get this logic working consistently everywhere!

@AbhiPrasad AbhiPrasad mentioned this pull request Jun 18, 2024
Merged
@AbhiPrasad
Copy link
Member

Closing this in favour of #12529 and getsentry/sentry-javascript-bundler-plugins#549

@AbhiPrasad AbhiPrasad closed this Jun 18, 2024
AbhiPrasad added a commit that referenced this pull request Jun 19, 2024
@AbhiPrasad
feat(node): Detect release from more providers (#12529)
fc165e5 
ref #12513

This PR upgrades release detection for Node and Vercel Edge SDKs.

This change adds release name detection for:

- GitLab CI
- AppVeyor
- AWS Amplify
- Azure Pipelines
- Bitrise
- Buddy CI
- Cirrus CI
- Codefresh
- Codemagic
- Semaphore CI
- Travis CI
- CloudBees CodeShip
- Coolify
- Jenkins
- TeamCity
- Woodpecker CI

Based on
getsentry/sentry-javascript-bundler-plugins#549

Supercedes #12507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcEspiard @AbhiPrasad