Revert "feat(core): Add parentSpan option to startSpan* APIs"

[AbhiPrasad]

Reverts #12567

Seems to have introduced test failures with esm preloading: https://github.com/getsentry/sentry-javascript/actions/runs/9599487906/job/26474052394

reverting this so we can unblock a release, we can investigate deeper afterwards.

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser	22.22 KB (0%)
@sentry/browser (incl. Tracing)	33.27 KB (-0.11% 🔽)
@sentry/browser (incl. Tracing, Replay)	69.05 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	62.37 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)	73.11 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback)	85.27 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)	87.09 KB (-0.09% 🔽)
@sentry/browser (incl. metrics)	26.42 KB (-0.29% 🔽)
@sentry/browser (incl. Feedback)	38.42 KB (0%)
@sentry/browser (incl. sendFeedback)	26.85 KB (0%)
@sentry/browser (incl. FeedbackAsync)	31.42 KB (0%)
@sentry/react	24.96 KB (0%)
@sentry/react (incl. Tracing)	36.32 KB (-0.1% 🔽)
@sentry/vue	26.23 KB (-0.36% 🔽)
@sentry/vue (incl. Tracing)	35.13 KB (-0.09% 🔽)
@sentry/svelte	22.35 KB (0%)
CDN Bundle	23.41 KB (0%)
CDN Bundle (incl. Tracing)	34.95 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay)	69.08 KB (-0.13% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)	74.25 KB (-0.12% 🔽)
CDN Bundle - uncompressed	68.76 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed	103.41 KB (-0.2% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed	213.88 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	226.47 KB (-0.09% 🔽)
@sentry/nextjs (client)	36.2 KB (-0.1% 🔽)
@sentry/sveltekit (client)	33.9 KB (-0.14% 🔽)
@sentry/node	112.94 KB (-0.05% 🔽)
@sentry/node - without tracing	90.35 KB (-0.05% 🔽)
@sentry/aws-serverless	99.44 KB (-0.05% 🔽)

[AbhiPrasad]

Okay so it's not this change, given the preload PR is still failing. I'm going to disable the test instead.

https://github.com/getsentry/sentry-javascript/actions/runs/9599998815/job/26475852827?pr=12587

Running 4 tests using 1 worker

  ✓  1 [chromium] › server.test.ts:4:5 › Should record exceptions captured inside handlers (199ms)
  ✓  2 [chromium] › server.test.ts:14:5 › Should record a transaction for a parameterless route (193ms)
  ✓  3 [chromium] › server.test.ts:24:5 › Should record a transaction for route with parameters (205ms)
  ✘  4 [chromium] › server.test.ts:125:5 › Should record spans from http instrumentation (145ms)


  1) [chromium] › server.test.ts:125:5 › Should record spans from http instrumentation ─────────────

    Error: expect(received).toEqual(expected) // deep equality

    Expected: {"data": {"http.flavor": "1.1", "http.host": "example.com:80", "http.method": "GET", "http.response.status_code": 200, "http.response_content_length_uncompressed": Any<Number>, "http.status_code": 200, "http.status_text": "OK", "http.target": "/", "http.url": "http://example.com/", "net.peer.ip": Any<String>, "net.peer.name": "example.com", "net.peer.port": 80, "net.transport": "ip_tcp", "otel.kind": "CLIENT", "sentry.op": "http.client", "sentry.origin": "auto.http.otel.http", "url": "http://example.com/"}, "description": "GET http://example.com/", "op": "http.client", "origin": "auto.http.otel.http", "parent_span_id": Any<String>, "span_id": Any<String>, "start_timestamp": Any<Number>, "status": "ok", "timestamp": Any<Number>, "trace_id": Any<String>}
    Received: undefined

      134 |   const httpClientSpan = transactionEvent.spans?.find(span => span.op === 'http.client');
      135 |
    > 136 |   expect(httpClientSpan).toEqual({
          |                          ^
      137 |     span_id: expect.any(String),
      138 |     trace_id: expect.any(String),
      139 |     data: {

        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/node-express-esm-preload/tests/server.test.ts:136:26