chore: Remove unneeded deps from main package.json #12644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
approved these changes
Jun 26, 2024
While working on my OTEL bump PR, I noticed some deps we no longer need. - @codecov/rollup-plugin can be removed because we dont use codecov bundle analysis atm - es-check can be removed because we don't check for es5 bundles anymore - replace-in-file can be removed for a simpler script with modern node apis Also bumped size-limit deps
AbhiPrasad
force-pushed
the
abhi-clean-up-deps
branch
from
c79c696 to
a21bf7d
Compare
size-limit report 📦
|
AbhiPrasad
changed the title
|
Removing multiple dependencies in a row is chaos - now the ts3.8 tests fail :( I might have to remove each dep individually in a PR 😢 |
This was referenced Jun 26, 2024
AbhiPrasad
added a commit
that referenced
this pull request
Jun 28, 2024
ref: #12644 We don't use `es-check` anymore, we can remove it. It was previously used to validate our es5 builds, but we don't target that anymore. Extracted from the previous PR because 1 big change was breaking CI and I couldn't figure out the root cause.
AbhiPrasad
added a commit
that referenced
this pull request
Jun 28, 2024
ref: #12644 We can remove `replace-in-file` with some built-in functions and clean up our lockfile even more. Extracted from the previous PR because 1 big change was breaking CI and I couldn't figure out the root cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my OTEL bump PR (#12635), I noticed some deps we no longer need.
@codecov/rollup-plugincan be removed because we dont use codecov bundle analysis atmes-checkcan be removed because we don't check for es5 bundles anymorereplace-in-filecan be removed for a simpler script with modern node apisinquirercan be removed in favour of simplerparseArgscall with Node~4700 lines from
yarn.lockis gone!Also bumped size-limit deps