Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(solid): Add e2e test app for solid sdk without solidrouter #12661

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

andreiborza
Copy link
Member

Moved the existing app to solid-solidrouter and created a new for solid without using any of the solid router integration.

@mydea
Copy link
Member

mydea commented Jun 26, 2024

nice!

this reminds me, actually we don't have an E2E test app for basic @sentry/browser, do we? 😅 we should probably also add that at some point, ensuring that the base browserTracingIntegration etc. work too 🙈

@andreiborza andreiborza merged commit 1092d77 into develop Jun 26, 2024
83 checks passed
@andreiborza andreiborza deleted the ab/solid-e2e-tests-no-router branch June 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants