fix(angular): Remove afterSendEvent listener once root injector is destroyed
#12786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/angular-rm-listener
branch
from
1c1690e
to
3bb8cc8
Compare
Lms24
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Hey @arturovt thanks for opening this PR!
The fix makes sense to me so I'm happy to merge this. Any chance you could add a small test to cover this? We already have some tests for showReportDialog in ErrorHandler so something similar to these would be great:
(Just a heads-up: I'm only assigning myself to the PR for internal tracking since I'm reviewing it)
Lms24
changed the title
afterSendEvent listener once root injector is destroyedafterSendEvent listener once root injector is destroyed
mydea
added a commit
that referenced
this pull request
Jul 11, 2024
Small optimization using the new hook cleanup capabilities to remove unused hooks. Ref PR to do this in angular: #12786
Lms24
approved these changes
Jul 18, 2024
…destroyed In this commit, we added cleanup logic to handle the removal of `afterSendEvent`, which is set up within the Angular error handler. This fixes memory leaks that occur when the event is still being handled after the root view is removed.
Lms24
force-pushed
the
fix/angular-rm-listener
branch
from
eae93f2
to
ed22329
Compare
andreiborza
added a commit
that referenced
this pull request
Jul 18, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #12786 --------- Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com> Co-authored-by: Andrei Borza <andrei.borza@sentry.io>
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we added cleanup logic to handle the removal of
afterSendEvent, which is set up within the Angular error handler. This fixes memory leaks that occur when the event is still being handled after the root view is removed.