Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): Add module to build:transpile script #12843

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(nuxt): Add module to build:transpile script #12843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/nuxt/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,19 @@ The minimum supported version of Nuxt is `3.0.0`.
This package is a wrapper around `@sentry/node` for the server and `@sentry/vue` for the client side, with added
functionality related to Nuxt.

What is working:

- Error Reporting

What is partly working:

- Tracing by setting `tracesSampleRate`

What is not yet(!) included:

- Source Maps
- Connected Traces
Comment on lines +31 to +42
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a more detailed description later. Just wanted to fix the module folder output right now and add some basic information along the way.


## Automatic Setup

todo: add wizard instructions
Expand Down
10 changes: 6 additions & 4 deletions packages/nuxt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@
"nuxt": "^3.12.2"
},
"scripts": {
"build": "run-p build:transpile build:types build:nuxt-module",
"build": "run-s build:types build:transpile",
"build:dev": "yarn build",
"build:nuxt-module": "nuxt-module-build build --outDir build/module",
"build:transpile": "rollup -c rollup.npm.config.mjs",
"build:transpile": "rollup -c rollup.npm.config.mjs && yarn build:nuxt-module",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:transpile:watch build:types:watch",
"build:dev:watch": "yarn build:watch",
Expand All @@ -84,10 +84,12 @@
"build:transpile": {
"dependsOn": [
"^build:transpile",
"^build:types"
"^build:types",
"build:types"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transpilation usually shouldn't depend on the same packages types. Is there a reason you added this?

Copy link
Member Author

@s1gr1d s1gr1d Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because I am building the module with nuxt-module-build and this already relies on the types. I am getting the build warning Potential missing package.json files: build/types/index.types.d.ts if there are no types yet.

],
"outputs": [
"{projectRoot}/build",
"{projectRoot}/build/cjs",
"{projectRoot}/build/esm",
"{projectRoot}/build/module"
]
}
Expand Down
Loading