fix(angular): Guard ErrorEvent check in ErrorHandler to avoid throwing in Node environments
#12892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in Node environments
Lms24
requested review from
a team,
AbhiPrasad and
chargome
and removed request for
a team
chargome
approved these changes
Jul 12, 2024
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for a "bug" mentioned in #12757 (comment)
This PR adds a guard for referencing
ErrorEventwhich is only available in browser environments but not in Node. Now, the errorHandler, as well as@sentry/angularin general is only expected to be run in browser environments. So this fix is technically not necessary at the moment but people nevertheless use@sentry/angularin Node environments so let's make their lives a bit easier.