fix(sveltekit): add Vite peer dep for proper type resolution #12926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).Hello! I am in the process of setting up the SvelteKit plugin within a monorepo that includes multiple applications with multiple versions of Vite. I've found that because
@sentry/sveltekit
does not specify a peer dependency onvite
,pnpm
picks up the wrongvite
version for the package'simport type { Plugin } from 'vite'
statement, causing type errors in my Vite config.This PR adds a simple, optional peer dependency on Vite to
@sentry/sveltekit
to ensure that it picks up whatever version of Vite is being used in the specific package it's installed in, without auto-installingvite
or anything disruptive like that. Let me know if you'd prefer specific versions spec'd rather than*
, or if you'd prefer to not mark the dependency asoptional: true
Note
I set up Volta as instructed in the Contributing guide and used the spec'd versions of Node and yarn. None of
yarn build
,yarn lint
, noryarn test
fully passed on my machine on a fresh copy of thedevelop
branch