fix(node): Ensure correct URL is passed to ignoreIncomingRequests callback
#12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...kages/node-integration-tests/suites/tracing/httpIntegration/server-ignoreOutgoingRequests.js
Dismissed
Show dismissed
Hide dismissed
Lms24
commented
Jul 16, 2024
| */ | ||
| export function startExpressServerAndSendPortToRunner(app: Express): void { | ||
| const server = app.listen(0, () => { | ||
| export function startExpressServerAndSendPortToRunner(app: Express, port: number | undefined = undefined): void { |
There was a problem hiding this comment.
small adjustment to our node integration tests framework: In the express apps, we can not optionally pass a fixed port which makes running the app locally a lot less painful 😅
3 tasks
mydea
reviewed
Jul 16, 2024
| @@ -103,7 +103,7 @@ export const instrumentHttp = Object.assign( | |||
| }, | |||
|
|
|||
| ignoreIncomingRequestHook: request => { | |||
| const url = getRequestUrl(request); | |||
| const url = request.url; | |||
There was a problem hiding this comment.
just checking to be sure, is the url here the full URL, including protocol? so e.g. http://...? As we want these to be full URLs I guess always, if possible.
There was a problem hiding this comment.
@mydea url is NOT the full url, it is instead just the path (and maybe the query params? EDIT: definitely has query params too.).
the node:IncomingMessage type doesn't have a protocol, hostname, or port attr.
- For protocol you'd have to do something like access
req.socket.encryptedand infer true === https - For hostname you'd have to parse the request headers for a Host header, falling back to req.socket.address() if it doesn't exist.
- For port you'd have to access
req.socket.address().port, I think.
So all that to say, sadly it's difficult to reconstruct the full url. Thoughts?
Screenshot:
There was a problem hiding this comment.
@mydea sorry i saw you moved your comment, so I just moved mine before I saw you replied 😅
I'll let you move your reply here so the comments aren't fragmented.
There was a problem hiding this comment.
Yeah, I feared that. IMHO this is OK, but we should maybe reflect this in the jsdoc/variables used for ignoreIncomingRequests, e.g. make it ignoreIncomingRequests(urlPath: string) or something like this?
Sounds reasonable to me but sadly this is a breaking change, no?
There was a problem hiding this comment.
Just changing the name of the variable is fine. Will make the change and update JSDoc and docs to reflect it. "Luckily" this never worked in v8 in the first place (afaict) so we're likely not behaviourally breaking folks.
There was a problem hiding this comment.
Regarding docs update: I'll do this in combination with the changes from #12930
size-limit report 📦
|
mydea
reviewed
Jul 16, 2024
mydea
approved these changes
Jul 16, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
alexandresoro
added a commit
to alexandresoro/ouca
that referenced
this pull request
Aug 16, 2024
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | major | [`7.119.0` -> `8.26.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/7.119.0/8.26.0) |
---
### Release Notes
<details>
<summary>getsentry/sentry-javascript (@​sentry/node)</summary>
### [`v8.26.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8260)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.25.0...8.26.0)
##### Important Changes
- **feat(node): Add `fsInstrumentation` ([#​13291](https://github.com/getsentry/sentry-javascript/issues/13291))**
This release adds `fsIntegration`, an integration that instruments the `fs` API to the Sentry Node SDK. The
integration creates spans with naming patterns of `fs.readFile`, `fs.unlink`, and so on.
This integration is not enabled by default and needs to be registered in your `Sentry.init` call. You can configure
via options whether to include path arguments or error messages as span attributes when an fs call fails:
```js
Sentry.init({
integrations: [
Sentry.fsIntegration({
recordFilePaths: true,
recordErrorMessagesAsSpanAttributes: true,
}),
],
});
```
**WARNING:** This integration may add significant overhead to your application. Especially in scenarios with a lot of
file I/O, like for example when running a framework dev server, including this integration can massively slow down
your application.
##### Other Changes
- feat(browser): Add spotlightBrowser integration ([#​13263](https://github.com/getsentry/sentry-javascript/issues/13263))
- feat(browser): Allow sentry in safari extension background page ([#​13209](https://github.com/getsentry/sentry-javascript/issues/13209))
- feat(browser): Send CLS as standalone span (experimental) ([#​13056](https://github.com/getsentry/sentry-javascript/issues/13056))
- feat(core): Add OpenTelemetry-specific `getTraceData` implementation ([#​13281](https://github.com/getsentry/sentry-javascript/issues/13281))
- feat(nextjs): Always add `browserTracingIntegration` ([#​13324](https://github.com/getsentry/sentry-javascript/issues/13324))
- feat(nextjs): Always transmit trace data to the client ([#​13337](https://github.com/getsentry/sentry-javascript/issues/13337))
- feat(nextjs): export SentryBuildOptions ([#​13296](https://github.com/getsentry/sentry-javascript/issues/13296))
- feat(nextjs): Update `experimental_captureRequestError` to reflect `RequestInfo.path` change in Next.js canary
([#​13344](https://github.com/getsentry/sentry-javascript/issues/13344))
- feat(nuxt): Always add tracing meta tags ([#​13273](https://github.com/getsentry/sentry-javascript/issues/13273))
- feat(nuxt): Set transaction name for server error ([#​13292](https://github.com/getsentry/sentry-javascript/issues/13292))
- feat(replay): Add a replay-specific logger ([#​13256](https://github.com/getsentry/sentry-javascript/issues/13256))
- feat(sveltekit): Add bundle size optimizations to plugin options ([#​13318](https://github.com/getsentry/sentry-javascript/issues/13318))
- feat(sveltekit): Always add browserTracingIntegration ([#​13322](https://github.com/getsentry/sentry-javascript/issues/13322))
- feat(tracing): Make long animation frames opt-out ([#​13255](https://github.com/getsentry/sentry-javascript/issues/13255))
- fix(astro): Correctly extract request data ([#​13315](https://github.com/getsentry/sentry-javascript/issues/13315))
- fix(astro): Only track access request headers in dynamic page requests ([#​13306](https://github.com/getsentry/sentry-javascript/issues/13306))
- fix(nuxt): Add import line for disabled `autoImport` ([#​13342](https://github.com/getsentry/sentry-javascript/issues/13342))
- fix(nuxt): Add vue to excludeEsmLoaderHooks array ([#​13346](https://github.com/getsentry/sentry-javascript/issues/13346))
- fix(opentelemetry): Do not overwrite http span name if kind is internal ([#​13282](https://github.com/getsentry/sentry-javascript/issues/13282))
- fix(remix): Ensure `origin` is correctly set for remix server spans ([#​13305](https://github.com/getsentry/sentry-javascript/issues/13305))
Work in this release was contributed by [@​MonstraG](https://github.com/MonstraG), [@​undead-voron](https://github.com/undead-voron) and [@​Zen-cronic](https://github.com/Zen-cronic). Thank you for your contributions!
### [`v8.25.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8250)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.24.0...8.25.0)
##### Important Changes
- **Alpha release of Official Solid Start SDK**
This release contains the alpha version of `@sentry/solidstart`, our SDK for [Solid Start](https://start.solidjs.com/)!
For details on how to use it, please see the [README](./packages/solidstart/README.md). Any feedback/bug reports are
greatly appreciated, please [reach out on GitHub](https://github.com/getsentry/sentry-javascript/issues/12538).
##### Other Changes
- feat(astro): Add `bundleSizeOptimizations` vite options to integration ([#​13250](https://github.com/getsentry/sentry-javascript/issues/13250))
- feat(astro): Always add BrowserTracing ([#​13244](https://github.com/getsentry/sentry-javascript/issues/13244))
- feat(core): Add `getTraceMetaTags` function ([#​13201](https://github.com/getsentry/sentry-javascript/issues/13201))
- feat(nestjs): Automatic instrumentation of nestjs exception filters ([#​13230](https://github.com/getsentry/sentry-javascript/issues/13230))
- feat(node): Add `useOperationNameForRootSpan` to`graphqlIntegration` ([#​13248](https://github.com/getsentry/sentry-javascript/issues/13248))
- feat(sveltekit): Add `wrapServerRouteWithSentry` wrapper ([#​13247](https://github.com/getsentry/sentry-javascript/issues/13247))
- fix(aws-serverless): Extract sentry trace data from handler `context` over `event` ([#​13266](https://github.com/getsentry/sentry-javascript/issues/13266))
- fix(browser): Initialize default integration if `defaultIntegrations: undefined` ([#​13261](https://github.com/getsentry/sentry-javascript/issues/13261))
- fix(utils): Streamline IP capturing on incoming requests ([#​13272](https://github.com/getsentry/sentry-javascript/issues/13272))
### [`v8.24.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8240)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.23.0...8.24.0)
- feat(nestjs): Filter RPC exceptions ([#​13227](https://github.com/getsentry/sentry-javascript/issues/13227))
- fix: Guard getReader function for other fetch implementations ([#​13246](https://github.com/getsentry/sentry-javascript/issues/13246))
- fix(feedback): Ensure feedback can be lazy loaded in CDN bundles ([#​13241](https://github.com/getsentry/sentry-javascript/issues/13241))
### [`v8.23.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8230)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.22.0...8.23.0)
##### Important Changes
- **feat(cloudflare): Add Cloudflare D1 instrumentation ([#​13142](https://github.com/getsentry/sentry-javascript/issues/13142))**
This release includes support for Cloudflare D1, Cloudflare's serverless SQL database. To instrument your Cloudflare D1
database, use the `instrumentD1WithSentry` method as follows:
```ts
// env.DB is the D1 DB binding configured in your `wrangler.toml`
const db = instrumentD1WithSentry(env.DB);
// Now you can use the database as usual
await db.prepare('SELECT * FROM table WHERE id = ?').bind(1).run();
```
##### Other Changes
- feat(cloudflare): Allow users to pass handler to sentryPagesPlugin ([#​13192](https://github.com/getsentry/sentry-javascript/issues/13192))
- feat(cloudflare): Instrument scheduled handler ([#​13114](https://github.com/getsentry/sentry-javascript/issues/13114))
- feat(core): Add `getTraceData` function ([#​13134](https://github.com/getsentry/sentry-javascript/issues/13134))
- feat(nestjs): Automatic instrumentation of nestjs interceptors before route execution ([#​13153](https://github.com/getsentry/sentry-javascript/issues/13153))
- feat(nestjs): Automatic instrumentation of nestjs pipes ([#​13137](https://github.com/getsentry/sentry-javascript/issues/13137))
- feat(nuxt): Filter out Nuxt build assets ([#​13148](https://github.com/getsentry/sentry-javascript/issues/13148))
- feat(profiling): Attach sdk info to chunks ([#​13145](https://github.com/getsentry/sentry-javascript/issues/13145))
- feat(solidstart): Add sentry `onBeforeResponse` middleware to enable distributed tracing ([#​13221](https://github.com/getsentry/sentry-javascript/issues/13221))
- feat(solidstart): Filter out low quality transactions for build assets ([#​13222](https://github.com/getsentry/sentry-javascript/issues/13222))
- fix(browser): Avoid showing browser extension error message in non-`window` global scopes ([#​13156](https://github.com/getsentry/sentry-javascript/issues/13156))
- fix(feedback): Call dialog.close() in dialog close callbacks in `\_loadAndRenderDialog` ([#​13203](https://github.com/getsentry/sentry-javascript/issues/13203))
- fix(nestjs): Inline Observable type to resolve missing 'rxjs' dependency ([#​13166](https://github.com/getsentry/sentry-javascript/issues/13166))
- fix(nuxt): Detect pageload by adding flag in Vue router ([#​13171](https://github.com/getsentry/sentry-javascript/issues/13171))
- fix(utils): Handle when requests get aborted in fetch instrumentation ([#​13202](https://github.com/getsentry/sentry-javascript/issues/13202))
- ref(browser): Improve browserMetrics collection ([#​13062](https://github.com/getsentry/sentry-javascript/issues/13062))
Work in this release was contributed by [@​horochx](https://github.com/horochx). Thank you for your contribution!
### [`v8.22.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8220)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.21.0...8.22.0)
##### Important Changes
- **feat(cloudflare): Add plugin for cloudflare pages ([#​13123](https://github.com/getsentry/sentry-javascript/issues/13123))**
This release adds support for Cloudflare Pages to `@sentry/cloudflare`, our SDK for the
[Cloudflare Workers JavaScript Runtime](https://developers.cloudflare.com/workers/)! For details on how to use it,
please see the [README](./packages/cloudflare/README.md). Any feedback/bug reports are greatly appreciated, please
[reach out on GitHub](https://github.com/getsentry/sentry-javascript/issues/12620).
```javascript
// functions/_middleware.js
import * as Sentry from '@​sentry/cloudflare';
export const onRequest = Sentry.sentryPagesPlugin({
dsn: __PUBLIC_DSN__,
// Set tracesSampleRate to 1.0 to capture 100% of spans for tracing.
tracesSampleRate: 1.0,
});
```
##### Other Changes
- feat(meta-sdks): Remove runtime tags ([#​13105](https://github.com/getsentry/sentry-javascript/issues/13105))
- feat(nestjs): Automatic instrumentation of nestjs guards ([#​13129](https://github.com/getsentry/sentry-javascript/issues/13129))
- feat(nestjs): Filter all HttpExceptions ([#​13120](https://github.com/getsentry/sentry-javascript/issues/13120))
- feat(replay): Capture exception when `internal_sdk_error` client report happens ([#​13072](https://github.com/getsentry/sentry-javascript/issues/13072))
- fix: Use `globalThis` for code injection ([#​13132](https://github.com/getsentry/sentry-javascript/issues/13132))
### [`v8.21.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8210)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.20.0...8.21.0)
##### Important Changes
- **Alpha release of Official Cloudflare SDK**
- feat(cloudflare): Add `withSentry` method ([#​13025](https://github.com/getsentry/sentry-javascript/issues/13025))
- feat(cloudflare): Add cloudflare sdk scaffolding ([#​12953](https://github.com/getsentry/sentry-javascript/issues/12953))
- feat(cloudflare): Add basic cloudflare package and tests ([#​12861](https://github.com/getsentry/sentry-javascript/issues/12861))
This release contains the alpha version of `@sentry/cloudflare`, our SDK for the
[Cloudflare Workers JavaScript Runtime](https://developers.cloudflare.com/workers/)! For details on how to use it,
please see the [README](./packages/cloudflare/README.md). Any feedback/bug reports are greatly appreciated, please
[reach out on GitHub](https://github.com/getsentry/sentry-javascript/issues/12620).
Please note that only Cloudflare Workers are tested and supported - official Cloudflare Pages support will come in an
upcoming release.
##### Other Changes
- feat(feedback): Make cropped screenshot area draggable ([#​13071](https://github.com/getsentry/sentry-javascript/issues/13071))
- feat(core): Adapt spans for client-side fetch to streaming responses ([#​12723](https://github.com/getsentry/sentry-javascript/issues/12723))
- feat(core): Capture # of dropped spans through `beforeSendTransaction` ([#​13022](https://github.com/getsentry/sentry-javascript/issues/13022))
- feat(deps): bump `@opentelemetry/instrumentation-aws-sdk` from 0.43.0 to 0.43.1 ([#​13089](https://github.com/getsentry/sentry-javascript/issues/13089))
- feat(deps): bump `@opentelemetry/instrumentation-express` from 0.41.0 to 0.41.1 ([#​13090](https://github.com/getsentry/sentry-javascript/issues/13090))
- feat(nestjs): Automatic instrumentation of nestjs middleware ([#​13065](https://github.com/getsentry/sentry-javascript/issues/13065))
- feat(node): Upgrade `import-in-the-middle` to 1.11.0 ([#​13107](https://github.com/getsentry/sentry-javascript/issues/13107))
- feat(nuxt): Add connected tracing meta tags ([#​13098](https://github.com/getsentry/sentry-javascript/issues/13098))
- feat(nuxt): Add vue-router instrumentation ([#​13054](https://github.com/getsentry/sentry-javascript/issues/13054))
- feat(solidstart): Add server action instrumentation helper ([#​13035](https://github.com/getsentry/sentry-javascript/issues/13035))
- fix(feedback): Ensure pluggable feedback CDN bundle is correctly built ([#​13081](https://github.com/getsentry/sentry-javascript/issues/13081))
- fix(nextjs): Only delete clientside bundle source maps with `sourcemaps.deleteFilesAfterUpload` ([#​13102](https://github.com/getsentry/sentry-javascript/issues/13102))
- fix(node): Improve OTEL validation logic ([#​13079](https://github.com/getsentry/sentry-javascript/issues/13079))
### [`v8.20.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8200)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.19.0...8.20.0)
##### Important Changes
- **feat(node): Allow to pass `registerEsmLoaderHooks` to preload ([#​12998](https://github.com/getsentry/sentry-javascript/issues/12998))**
You can write your own custom preload script and configure this in the preload options. `registerEsmLoaderHooks` can be
passed as an option to `preloadOpenTelemetry`, which allows to exclude/include packages in the preload.
- **fix(node): Do not emit fetch spans when tracing is disabled ([#​13003](https://github.com/getsentry/sentry-javascript/issues/13003))**
Sentry will not emit "fetch" spans if tracing is disabled. This is relevant for user who use their own sampler.
##### Other Changes
- feat(feedback): Trigger button aria label configuration ([#​13008](https://github.com/getsentry/sentry-javascript/issues/13008))
- feat(nestjs): Change nest sdk setup ([#​12920](https://github.com/getsentry/sentry-javascript/issues/12920))
- feat(node): Extend ESM hooks options for iitm v1.10.0 ([#​13016](https://github.com/getsentry/sentry-javascript/issues/13016))
- feat(node): Send client reports ([#​12951](https://github.com/getsentry/sentry-javascript/issues/12951))
- feat(nuxt): Automatically add BrowserTracing ([#​13005](https://github.com/getsentry/sentry-javascript/issues/13005))
- feat(nuxt): Setup source maps with vite config ([#​13018](https://github.com/getsentry/sentry-javascript/issues/13018))
- feat(replay): Improve public Replay APIs ([#​13000](https://github.com/getsentry/sentry-javascript/issues/13000))
### [`v8.19.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#For-Nodejs--18190)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.18.0...8.19.0)
node --import=@​sentry/node/import app.js
````
- **feat(node): Do not exit process by default when other `onUncaughtException` handlers are registered in
`onUncaughtExceptionIntegration` (#​11532)**
In v8, we will no longer exit the node process by default if other uncaught exception handlers have been registered by
the user.
- **Better handling of transaction name for errors**
We improved the way we keep the transaction name for error events, even when spans are not sampled or performance is
disabled.
- feat(fastify): Update scope `transactionName` when handling request (#​11447)
- feat(hapi): Update scope `transactionName` when handling request (#​11448)
- feat(koa): Update scope `transactionName` when creating router span (#​11476)
- feat(sveltekit): Update scope transactionName when handling server-side request (#​11511)
- feat(nestjs): Update scope transaction name with parameterized route (#​11510)
##### Removal/Refactoring of deprecated functionality
- feat(core): Remove `getCurrentHub` from `AsyncContextStrategy` (#​11581)
- feat(core): Remove `getGlobalHub` export (#​11565)
- feat(core): Remove `Hub` class export (#​11560)
- feat(core): Remove most Hub class exports (#​11536)
- feat(nextjs): Remove webpack 4 support (#​11605)
- feat(vercel-edge): Stop using hub (#​11539)
##### Other Changes
- feat: Hoist `getCurrentHub` shim to core as `getCurrentHubShim` (#​11537)
- feat(core): Add default behaviour for `rewriteFramesIntegration` in browser (#​11535)
- feat(core): Ensure replay envelopes are sent in order when offline (#​11413)
- feat(core): Extract errors from props in unkown inputs (#​11526)
- feat(core): Update metric normalization (#​11518)
- feat(feedback): Customize feedback placeholder text color (#​11417)
- feat(feedback): Maintain v7 compat in the @​sentry-internal/feedback package (#​11461)
- feat(next): Handle existing root spans for isolation scope (#​11479)
- feat(node): Ensure tracing without performance (TWP) works (#​11564)
- feat(opentelemetry): Export `getRequestSpanData` (#​11508)
- feat(opentelemetry): Remove otel.attributes in context (#​11604)
- feat(ratelimit): Add metrics rate limit (#​11538)
- feat(remix): Skip span creation for `OPTIONS` and `HEAD` requests. (#​11149)
- feat(replay): Merge packages together & ensure bundles are built (#​11552)
- feat(tracing): Adds span envelope and datacategory (#​11534)
- fix(browser): Ensure pageload trace remains active after pageload span finished (#​11600)
- fix(browser): Ensure tracing without performance (TWP) works (#​11561)
- fix(nextjs): Fix `tunnelRoute` matching logic for hybrid cloud (#​11576)
- fix(nextjs): Remove Http integration from Next.js (#​11304)
- fix(node): Ensure isolation scope is correctly cloned for non-recording spans (#​11503)
- fix(node): Make fastify types more broad (#​11544)
- fix(node): Send ANR events without scope if event loop blocked indefinitely (#​11578)
- fix(tracing): Fixes latest route name and source not updating correctly (#​11533)
- ref(browser): Move browserTracing into browser pkg (#​11484)
- ref(feedback): Configure font size (#​11437)
- ref(feedback): Refactor Feedback types into @​sentry/types and reduce the exported surface area (#​11355)
#### 8.0.0-beta.0
This release failed to publish correctly. Use 8.0.0-beta.1 instead.
#### 8.0.0-alpha.9
This is the eighth alpha release of Sentry JavaScript SDK v8, which includes a variety of breaking changes.
Read the [in-depth migration guide](./MIGRATION.md) to find out how to address any breaking changes in your code.
##### Important Changes
- **feat: Add @​sentry-internal/browser-utils (#​11381)**
A big part of the browser-runtime specific exports of the internal `@sentry/utils` package were moved into a new package
`@sentry-internal/browser-utils`. If you imported any API from `@sentry/utils` (which is generally not recommended but
necessary for some workarounds), please check that your import statements still point to existing exports after
upgrading.
- **feat: Add loader file to node-based SDKs to support ESM monkeypatching (#​11338)**
When using ESM, it is necessary to use a "loader" to be able to instrument certain third-party packages and Node.js API.
The server-side SDKs now ship with a set of ESM loader hooks, that should be used when using ESM. Use them as follows:
```sh
````
### [`v8.18.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8180)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.17.0...8.18.0)
##### Important Changes
- **ref: Deprecate `enableTracing` (12897)**
The `enableTracing` option has been deprecated and will be removed in the next major version. We recommend removing it
in favor of the `tracesSampleRate` and `tracesSampler` options. If you want to enable performance monitoring, please set
the `tracesSampleRate` to a sample rate of your choice, or provide a sampling function as `tracesSampler` option
instead. If you want to disable performance monitoring, remove the `tracesSampler` and `tracesSampleRate` options.
##### Other Changes
- feat(node): Expose `exclude` and `include` options for ESM loader ([#​12910](https://github.com/getsentry/sentry-javascript/issues/12910))
- feat(browser): Add user agent to INP standalone span attributes ([#​12896](https://github.com/getsentry/sentry-javascript/issues/12896))
- feat(nextjs): Add `experimental_captureRequestError` for `onRequestError` hook ([#​12885](https://github.com/getsentry/sentry-javascript/issues/12885))
- feat(replay): Bump `rrweb` to 2.25.0 ([#​12478](https://github.com/getsentry/sentry-javascript/issues/12478))
- feat(tracing): Add long animation frame tracing ([#​12646](https://github.com/getsentry/sentry-javascript/issues/12646))
- fix: Cleanup hooks when they are not used anymore ([#​12852](https://github.com/getsentry/sentry-javascript/issues/12852))
- fix(angular): Guard `ErrorEvent` check in ErrorHandler to avoid throwing in Node environments ([#​12892](https://github.com/getsentry/sentry-javascript/issues/12892))
- fix(inp): Ensure INP spans have correct transaction ([#​12871](https://github.com/getsentry/sentry-javascript/issues/12871))
- fix(nestjs): Do not make SentryTraced() decorated functions async ([#​12879](https://github.com/getsentry/sentry-javascript/issues/12879))
- fix(nextjs): Support automatic instrumentation for app directory with custom page extensions ([#​12858](https://github.com/getsentry/sentry-javascript/issues/12858))
- fix(node): Ensure correct URL is passed to `ignoreIncomingRequests` callback ([#​12929](https://github.com/getsentry/sentry-javascript/issues/12929))
- fix(otel): Do not add `otel.kind: INTERNAL` attribute ([#​12841](https://github.com/getsentry/sentry-javascript/issues/12841))
- fix(solidstart): Set proper sentry origin for solid router integration when used in solidstart sdk ([#​12919](https://github.com/getsentry/sentry-javascript/issues/12919))
- fix(sveltekit): Add Vite peer dep for proper type resolution ([#​12926](https://github.com/getsentry/sentry-javascript/issues/12926))
- fix(tracing): Ensure you can pass `null` as `parentSpan` in `startSpan*` ([#​12928](https://github.com/getsentry/sentry-javascript/issues/12928))
- ref(core): Small bundle size improvement ([#​12830](https://github.com/getsentry/sentry-javascript/issues/12830))
Work in this release was contributed by [@​GitSquared](https://github.com/GitSquared), [@​ziyadkhalil](https://github.com/ziyadkhalil) and [@​mcous](https://github.com/mcous). Thank you for your contributions!
### [`v8.17.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8170)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.16.0...8.17.0)
- feat: Upgrade OTEL deps ([#​12809](https://github.com/getsentry/sentry-javascript/issues/12809))
- fix(nuxt): Add module to build:transpile script ([#​12843](https://github.com/getsentry/sentry-javascript/issues/12843))
- fix(browser): Allow SDK initialization in NW.js apps ([#​12846](https://github.com/getsentry/sentry-javascript/issues/12846))
### [`v8.16.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8160)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.15.0...8.16.0)
##### Important Changes
- **feat(nextjs): Use spans generated by Next.js for App Router ([#​12729](https://github.com/getsentry/sentry-javascript/issues/12729))**
Previously, the `@sentry/nextjs` SDK automatically recorded spans in the form of transactions for each of your top-level
server components (pages, layouts, ...). This approach had a few drawbacks, the main ones being that traces didn't have
a root span, and more importantly, if you had data stream to the client, its duration was not captured because the
server component spans had finished before the data could finish streaming.
With this release, we will capture the duration of App Router requests in their entirety as a single transaction with
server component spans being descendants of that transaction. This means you will get more data that is also more
accurate. Note that this does not apply to the Edge runtime. For the Edge runtime, the SDK will emit transactions as it
has before.
Generally speaking, this change means that you will see less *transactions* and more *spans* in Sentry. You will no
longer receive server component transactions like `Page Server Component (/path/to/route)` (unless using the Edge
runtime), and you will instead receive transactions for your App Router SSR requests that look like
`GET /path/to/route`.
If you are on Sentry SaaS, this may have an effect on your quota consumption: Less transactions, more spans.
- **- feat(nestjs): Add nest cron monitoring support ([#​12781](https://github.com/getsentry/sentry-javascript/issues/12781))**
The `@sentry/nestjs` SDK now includes a `@SentryCron` decorator that can be used to augment the native NestJS `@Cron`
decorator to send check-ins to Sentry before and after each cron job run:
```typescript
import { Cron } from '@​nestjs/schedule';
import { SentryCron, MonitorConfig } from '@​sentry/nestjs';
import type { MonitorConfig } from '@​sentry/types';
const monitorConfig: MonitorConfig = {
schedule: {
type: 'crontab',
value: '* * * * *',
},
checkinMargin: 2, // In minutes. Optional.
maxRuntime: 10, // In minutes. Optional.
timezone: 'America/Los_Angeles', // Optional.
};
export class MyCronService {
@​Cron('* * * * *')
@​SentryCron('my-monitor-slug', monitorConfig)
handleCron() {
// Your cron job logic here
}
}
```
##### Other Changes
- feat(node): Allow to pass instrumentation config to `httpIntegration` ([#​12761](https://github.com/getsentry/sentry-javascript/issues/12761))
- feat(nuxt): Add server error hook ([#​12796](https://github.com/getsentry/sentry-javascript/issues/12796))
- feat(nuxt): Inject sentry config with Nuxt `addPluginTemplate` ([#​12760](https://github.com/getsentry/sentry-javascript/issues/12760))
- fix: Apply stack frame metadata before event processors ([#​12799](https://github.com/getsentry/sentry-javascript/issues/12799))
- fix(feedback): Add missing `h` import in `ScreenshotEditor` ([#​12784](https://github.com/getsentry/sentry-javascript/issues/12784))
- fix(node): Ensure `autoSessionTracking` is enabled by default ([#​12790](https://github.com/getsentry/sentry-javascript/issues/12790))
- ref(feedback): Let CropCorner inherit the existing h prop ([#​12814](https://github.com/getsentry/sentry-javascript/issues/12814))
- ref(otel): Ensure we never swallow args for ContextManager ([#​12798](https://github.com/getsentry/sentry-javascript/issues/12798))
### [`v8.15.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8150)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.14.0...8.15.0)
- feat(core): allow unregistering callback through `on` ([#​11710](https://github.com/getsentry/sentry-javascript/issues/11710))
- feat(nestjs): Add function-level span decorator to nestjs ([#​12721](https://github.com/getsentry/sentry-javascript/issues/12721))
- feat(otel): Export & use `spanTimeInputToSeconds` for otel span exporter ([#​12699](https://github.com/getsentry/sentry-javascript/issues/12699))
- fix(core): Pass origin as referrer for `lazyLoadIntegration` ([#​12766](https://github.com/getsentry/sentry-javascript/issues/12766))
- fix(deno): Publish from build directory ([#​12773](https://github.com/getsentry/sentry-javascript/issues/12773))
- fix(hapi): Specify error channel to filter boom errors ([#​12725](https://github.com/getsentry/sentry-javascript/issues/12725))
- fix(react): Revert back to `jsxRuntime: 'classic'` to prevent breaking react 17 ([#​12775](https://github.com/getsentry/sentry-javascript/issues/12775))
- fix(tracing): Report dropped spans for transactions ([#​12751](https://github.com/getsentry/sentry-javascript/issues/12751))
- ref(scope): Delete unused public `getStack()` ([#​12737](https://github.com/getsentry/sentry-javascript/issues/12737))
Work in this release was contributed by [@​arturovt](https://github.com/arturovt) and [@​jaulz](https://github.com/jaulz). Thank you for your contributions!
### [`v8.14.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8140)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.13.0...8.14.0)
##### Important Changes
- **feat(nestjs): Filter 4xx errors ([#​12695](https://github.com/getsentry/sentry-javascript/issues/12695))**
The `@sentry/nestjs` SDK no longer captures 4xx errors automatically.
##### Other Changes
- chore(react): Remove private namespace `JSX` ([#​12691](https://github.com/getsentry/sentry-javascript/issues/12691))
- feat(deps): bump [@​opentelemetry/propagator-aws-xray](https://github.com/opentelemetry/propagator-aws-xray) from 1.25.0 to 1.25.1 ([#​12719](https://github.com/getsentry/sentry-javascript/issues/12719))
- feat(deps): bump [@​prisma/instrumentation](https://github.com/prisma/instrumentation) from 5.16.0 to 5.16.1 ([#​12718](https://github.com/getsentry/sentry-javascript/issues/12718))
- feat(node): Add `registerEsmLoaderHooks` option ([#​12684](https://github.com/getsentry/sentry-javascript/issues/12684))
- feat(opentelemetry): Expose sampling helper ([#​12674](https://github.com/getsentry/sentry-javascript/issues/12674))
- fix(browser): Make sure measure spans have valid start timestamps ([#​12648](https://github.com/getsentry/sentry-javascript/issues/12648))
- fix(hapi): Widen type definitions ([#​12710](https://github.com/getsentry/sentry-javascript/issues/12710))
- fix(nextjs): Attempt to ignore critical dependency warnings ([#​12694](https://github.com/getsentry/sentry-javascript/issues/12694))
- fix(react): Fix React jsx runtime import for esm ([#​12740](https://github.com/getsentry/sentry-javascript/issues/12740))
- fix(replay): Start replay in `afterAllSetup` instead of next tick ([#​12709](https://github.com/getsentry/sentry-javascript/issues/12709))
Work in this release was contributed by [@​quisido](https://github.com/quisido). Thank you for your contribution!
### [`v8.13.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8130)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.12.0...8.13.0)
##### Important Changes
- **feat(nestjs): Add Nest SDK** This release adds a dedicated SDK for [NestJS](https://nestjs.com/) (`@sentry/nestjs`)
in alpha state. The SDK is a drop-in replacement for the Sentry Node SDK (`@sentry/node`) supporting the same set of
features. See the [docs](https://docs.sentry.io/platforms/javascript/guides/nestjs/) for how to use the SDK.
##### Other Changes
- deps: Bump bundler plugins to `2.20.1` ([#​12641](https://github.com/getsentry/sentry-javascript/issues/12641))
- deps(nextjs): Remove react peer dep and allow rc ([#​12670](https://github.com/getsentry/sentry-javascript/issues/12670))
- feat: Update OTEL deps ([#​12635](https://github.com/getsentry/sentry-javascript/issues/12635))
- feat(deps): bump [@​prisma/instrumentation](https://github.com/prisma/instrumentation) from 5.15.0 to 5.15.1 ([#​12627](https://github.com/getsentry/sentry-javascript/issues/12627))
- feat(node): Add context info for missing instrumentation ([#​12639](https://github.com/getsentry/sentry-javascript/issues/12639))
- fix(feedback): Improve feedback error message ([#​12647](https://github.com/getsentry/sentry-javascript/issues/12647))
### [`v8.12.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8120)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.11.0...8.12.0)
##### Important Changes
- **feat(solid): Remove need to pass router hooks to solid integration** (breaking)
This release introduces breaking changes to the `@sentry/solid` package (which is currently out in alpha).
We've made it easier to get started with the solid router integration by removing the need to pass **use\*** hooks
explicitly to `solidRouterBrowserTracingIntegration`. Import `solidRouterBrowserTracingIntegration` from
`@sentry/solid/solidrouter` and add it to `Sentry.init`
```js
import * as Sentry from '@​sentry/solid';
import { solidRouterBrowserTracingIntegration, withSentryRouterRouting } from '@​sentry/solid/solidrouter';
import { Router } from '@​solidjs/router';
Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [solidRouterBrowserTracingIntegration()],
tracesSampleRate: 1.0, // Capture 100% of the transactions
});
const SentryRouter = withSentryRouterRouting(Router);
```
- **feat(core): Return client from init method ([#​12585](https://github.com/getsentry/sentry-javascript/issues/12585))**
`Sentry.init()` now returns a client directly, so you don't need to explicitly call `getClient()` anymore:
```js
const client = Sentry.init();
```
- **feat(nextjs): Add `deleteSourcemapsAfterUpload` option ([#​12457](https://github.com/getsentry/sentry-javascript/issues/12457))**
This adds an easy way to delete sourcemaps immediately after uploading them:
```js
module.exports = withSentryConfig(nextConfig, {
sourcemaps: {
deleteSourcemapsAfterUpload: true,
},
});
```
- **feat(node): Allow to configure `maxSpanWaitDuration` ([#​12610](https://github.com/getsentry/sentry-javascript/issues/12610))**
Adds configuration option for the max. duration in seconds that the SDK will wait for parent spans to be finished before
discarding a span. The SDK will automatically clean up spans that have no finished parent after this duration. This is
necessary to prevent memory leaks in case of parent spans that are never finished or otherwise dropped/missing. However,
if you have very long-running spans in your application, a shorter duration might cause spans to be discarded too early.
In this case, you can increase this duration to a value that fits your expected data.
##### Other Changes
- feat(feedback): Extra check for iPad in screenshot support ([#​12593](https://github.com/getsentry/sentry-javascript/issues/12593))
- fix(bundle): Ensure CDN bundles do not overwrite `window.Sentry` ([#​12580](https://github.com/getsentry/sentry-javascript/issues/12580))
- fix(feedback): Inject preact from feedbackModal into feedbackScreenshot integration ([#​12535](https://github.com/getsentry/sentry-javascript/issues/12535))
- fix(node): Re-throw errors from koa middleware ([#​12609](https://github.com/getsentry/sentry-javascript/issues/12609))
- fix(remix): Mark `isRemixV2` as optional in exposed types. ([#​12614](https://github.com/getsentry/sentry-javascript/issues/12614))
- ref(node): Add error message to NodeFetch log ([#​12612](https://github.com/getsentry/sentry-javascript/issues/12612))
Work in this release was contributed by [@​n4bb12](https://github.com/n4bb12). Thank you for your contribution!
### [`v8.11.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8110)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.10.0...8.11.0)
##### Important Changes
- **feat(core): Add `parentSpan` option to `startSpan*` APIs ([#​12567](https://github.com/getsentry/sentry-javascript/issues/12567))**
We've made it easier to create a span as a child of a specific span via the startSpan\* APIs. This should allow you to
explicitly manage the parent-child relationship of your spans better.
```js
Sentry.startSpan({ name: 'root' }, parent => {
const span = Sentry.startInactiveSpan({ name: 'xxx', parentSpan: parent });
Sentry.startSpan({ name: 'xxx', parentSpan: parent }, () => {});
Sentry.startSpanManual({ name: 'xxx', parentSpan: parent }, () => {});
});
```
##### Other Changes
- feat(node): Detect release from more providers ([#​12529](https://github.com/getsentry/sentry-javascript/issues/12529))
- fix(profiling-node): Use correct getGlobalScope import ([#​12564](https://github.com/getsentry/sentry-javascript/issues/12564))
- fix(profiling-node) sample timestamps need to be in seconds ([#​12563](https://github.com/getsentry/sentry-javascript/issues/12563))
- ref: Align `@sentry/node` exports from framework SDKs. ([#​12589](https://github.com/getsentry/sentry-javascript/issues/12589))
### [`v8.10.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8100)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.9.2...8.10.0)
##### Important Changes
- **feat(remix): Migrate to `opentelemetry-instrumentation-remix`. ([#​12110](https://github.com/getsentry/sentry-javascript/issues/12110))**
You can now simplify your remix instrumentation by opting-in like this:
```js
const Sentry = require('@​sentry/remix');
Sentry.init({
dsn: YOUR_DSN
// opt-in to new auto instrumentation
autoInstrumentRemix: true,
});
```
With this setup, you do not need to add e.g. `wrapExpressCreateRequestHandler` anymore. Additionally, the quality of the
captured data improves. The old way to use `@sentry/remix` continues to work, but it is encouraged to use the new setup.
##### Other Changes
- feat(browser): Export `thirdPartyErrorFilterIntegration` from `@sentry/browser` ([#​12512](https://github.com/getsentry/sentry-javascript/issues/12512))
- feat(feedback): Allow passing `tags` field to any feedback config param ([#​12197](https://github.com/getsentry/sentry-javascript/issues/12197))
- feat(feedback): Improve screenshot quality for retina displays ([#​12487](https://github.com/getsentry/sentry-javascript/issues/12487))
- feat(feedback): Screenshots don't resize after cropping ([#​12481](https://github.com/getsentry/sentry-javascript/issues/12481))
- feat(node) add max lineno and colno limits ([#​12514](https://github.com/getsentry/sentry-javascript/issues/12514))
- feat(profiling) add global profile context while profiler is running ([#​12394](https://github.com/getsentry/sentry-javascript/issues/12394))
- feat(react): Add React version to events ([#​12390](https://github.com/getsentry/sentry-javascript/issues/12390))
- feat(replay): Add url to replay hydration error breadcrumb type ([#​12521](https://github.com/getsentry/sentry-javascript/issues/12521))
- fix(core): Ensure standalone spans respect sampled flag ([#​12533](https://github.com/getsentry/sentry-javascript/issues/12533))
- fix(core): Use maxValueLength in extra error data integration ([#​12174](https://github.com/getsentry/sentry-javascript/issues/12174))
- fix(feedback): Fix scrolling after feedback submission ([#​12499](https://github.com/getsentry/sentry-javascript/issues/12499))
- fix(feedback): Send feedback rejects invalid responses ([#​12518](https://github.com/getsentry/sentry-javascript/issues/12518))
- fix(nextjs): Update [@​rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) ([#​12527](https://github.com/getsentry/sentry-javascript/issues/12527))
- fix(node): Ensure status is correct for http server span errors ([#​12477](https://github.com/getsentry/sentry-javascript/issues/12477))
- fix(node): Unify`getDynamicSamplingContextFromSpan` ([#​12522](https://github.com/getsentry/sentry-javascript/issues/12522))
- fix(profiling): continuous profile chunks should be in seconds ([#​12532](https://github.com/getsentry/sentry-javascript/issues/12532))
- fix(remix): Add nativeFetch support for accessing request headers ([#​12479](https://github.com/getsentry/sentry-javascript/issues/12479))
- fix(remix): Export no-op as `captureRemixServerException` from client SDK ([#​12497](https://github.com/getsentry/sentry-javascript/issues/12497))
- ref(node) refactor contextlines to use readline ([#​12221](https://github.com/getsentry/sentry-javascript/issues/12221))
Work in this release was contributed by [@​AndreyKovanov](https://github.com/AndreyKovanov) and [@​kiliman](https://github.com/kiliman). Thank you for your contributions!
### [`v8.9.2`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#892)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.9.1...8.9.2)
- fix(profiling): Update exports so types generate properly ([#​12469](https://github.com/getsentry/sentry-javascript/issues/12469))
### [`v8.9.1`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#891)
##### Important changes
- **feat(solid): Add Solid SDK**
This release adds a dedicated SDK for [Solid JS](https://www.solidjs.com/) in alpha state with instrumentation for
[Solid Router](https://docs.solidjs.com/solid-router) and a custom `ErrorBoundary`. See the
[package README](https://github.com/getsentry/sentry-javascript/blob/develop/packages/solid/README.md) for how to use
the SDK.
##### Other changes
- feat(deps): bump [@​opentelemetry/instrumentation-express](https://github.com/opentelemetry/instrumentation-express) from 0.40.0 to 0.40.1 ([#​12438](https://github.com/getsentry/sentry-javascript/issues/12438))
- feat(deps): bump [@​opentelemetry/instrumentation-mongodb](https://github.com/opentelemetry/instrumentation-mongodb) from 0.44.0 to 0.45.0 ([#​12439](https://github.com/getsentry/sentry-javascript/issues/12439))
- feat(deps): bump [@​opentelemetry/propagator-aws-xray](https://github.com/opentelemetry/propagator-aws-xray) from 1.24.1 to 1.25.0 ([#​12437](https://github.com/getsentry/sentry-javascript/issues/12437))
- feat(nextjs): Allow for suppressing warning about missing global error handler file ([#​12369](https://github.com/getsentry/sentry-javascript/issues/12369))
- feat(redis): Add cache logic for redis-4 ([#​12429](https://github.com/getsentry/sentry-javascript/issues/12429))
- feat(replay): Replay Web Vital Breadcrumbs ([#​12296](https://github.com/getsentry/sentry-javascript/issues/12296))
- fix: Fix types export order ([#​12404](https://github.com/getsentry/sentry-javascript/issues/12404))
- fix(astro): Ensure server-side exports work correctly ([#​12453](https://github.com/getsentry/sentry-javascript/issues/12453))
- fix(aws-serverless): Add `op` to Otel-generated lambda function root span ([#​12430](https://github.com/getsentry/sentry-javascript/issues/12430))
- fix(aws-serverless): Only auto-patch handler in CJS when loading `awslambda-auto` ([#​12392](https://github.com/getsentry/sentry-javascript/issues/12392))
- fix(aws-serverless): Only start root span in Sentry wrapper if Otel didn't wrap handler ([#​12407](https://github.com/getsentry/sentry-javascript/issues/12407))
- fix(browser): Fix INP span creation & transaction tagging ([#​12372](https://github.com/getsentry/sentry-javascript/issues/12372))
- fix(nextjs): correct types conditional export ordering ([#​12355](https://github.com/getsentry/sentry-javascript/issues/12355))
- fix(replay): Fix guard for exception event ([#​12441](https://github.com/getsentry/sentry-javascript/issues/12441))
- fix(vue): Handle span name assignment for nested routes in VueRouter ([#​12398](https://github.com/getsentry/sentry-javascript/issues/12398))
Work in this release was contributed by [@​soch4n](https://github.com/soch4n). Thank you for your contribution!
### [`v8.9.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#890)
This release failed to publish correctly, please use `8.9.1` instead.
### [`v8.8.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#880)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.7.0...8.8.0)
- **feat: Upgrade OTEL dependencies ([#​12388](https://github.com/getsentry/sentry-javascript/issues/12388))**
This upgrades the OpenTelemetry dependencies to the latest versions and makes OTEL use `import-in-the-middle` `v1.8.0`.
This should fix numerous issues with using OTEL instrumentation with ESM.
High level issues fixed with OTEL + ESM:
- incompatibilities with using multiple loaders, commonly encountered while using `tsx` or similar libraries.
- incompatibilities with libraries that use duplicate namespace exports like `date-fns`.
- incompatibilities with libraries that use self-referencing namespace imports like `openai`.
- incompatibilities with dynamic export patterns like exports with function calls.
- `ENOENT: no such file or directory` bugs that libraries like [`discord.js`](https://github.com/discordjs/discord.js)
surface.
If you are still encountering issues with OpenTelemetry instrumentation and ESM, please let us know.
- deps: Bump Sentry bundler plugins to version `2.18.0` ([#​12381](https://github.com/getsentry/sentry-javascript/issues/12381))
- feat: Add `thirdPartyErrorFilterIntegration` ([#​12267](https://github.com/getsentry/sentry-javascript/issues/12267))
- feat(core): Filter out error events with exception values and no stacktraces, values, or types ([#​12387](https://github.com/getsentry/sentry-javascript/issues/12387))
- feat(core): Ignore additional common but inactionable errors ([#​12384](https://github.com/getsentry/sentry-javascript/issues/12384))
- feat(deps): Bump [@​opentelemetry/propagator-aws-xray](https://github.com/opentelemetry/propagator-aws-xray) from 1.3.1 to 1.24.1 ([#​12333](https://github.com/getsentry/sentry-javascript/issues/12333))
- feat(deps): Bump [@​sentry/cli](https://github.com/sentry/cli) from 2.31.2 to 2.32.1 ([#​12332](https://github.com/getsentry/sentry-javascript/issues/12332))
- feat(redis): Support `mget` command in caching functionality ([#​12380](https://github.com/getsentry/sentry-javascript/issues/12380))
- feat(vercel-edge): Export core integrations from Vercel edge SDK ([#​12308](https://github.com/getsentry/sentry-javascript/issues/12308))
- fix(browser): Fix idle span ending ([#​12306](https://github.com/getsentry/sentry-javascript/issues/12306))
- fix(browser): Fix parenthesis parsing logic for chromium ([#​12373](https://github.com/getsentry/sentry-javascript/issues/12373))
- fix(browser): Fix types export path for CJS ([#​12305](https://github.com/getsentry/sentry-javascript/issues/12305))
- fix(feedback): Override TriggerLabel Option ([#​12316](https://github.com/getsentry/sentry-javascript/issues/12316))
- fix(feedback): Wait for document to be ready before doing autoinject ([#​12294](https://github.com/getsentry/sentry-javascript/issues/12294))
- fix(nextjs): Fix memory leak ([#​12335](https://github.com/getsentry/sentry-javascript/issues/12335))
- fix(nextjs): Fix version detection and option insertion logic for `clientTraceMetadata` option ([#​12323](https://github.com/getsentry/sentry-javascript/issues/12323))
- fix(nextjs): Update argument name in log message about `sentry` property on Next.js config object ([#​12366](https://github.com/getsentry/sentry-javascript/issues/12366))
- fix(node): Do not manually finish / update root Hapi spans. ([#​12287](https://github.com/getsentry/sentry-javascript/issues/12287))
- fix(node): Fix virtual parent span ID handling & update create-next-app E2E test ([#​12368](https://github.com/getsentry/sentry-javascript/issues/12368))
- fix(node): Skip capturing Hapi Boom responses v8. ([#​12288](https://github.com/getsentry/sentry-javascript/issues/12288))
- fix(performance): Fix LCP not getting picked up on initial pageload transaction by setting reportAllChanges to true
([#​12360](https://github.com/getsentry/sentry-javascript/issues/12360))
- fix(replay): Avoid infinite loop of logs ([#​12309](https://github.com/getsentry/sentry-javascript/issues/12309))
- fix(replay): Ignore old events when manually starting replay ([#​12349](https://github.com/getsentry/sentry-javascript/issues/12349))
- ref(browser): Ensure idle span ending is consistent ([#​12310](https://github.com/getsentry/sentry-javascript/issues/12310))
- ref(profiling): unref timer ([#​12340](https://github.com/getsentry/sentry-javascript/issues/12340))
Work in this release contributed by [@​dohooo](https://github.com/dohooo), [@​mohd-akram](https://github.com/mohd-akram), and [@​ykzts](https://github.com/ykzts). Thank you for your contributions!
### [`v8.7.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#870)
##### Important Changes
- **feat(react): Add TanStack Router integration ([#​12095](https://github.com/getsentry/sentry-javascript/issues/12095))**
This release adds instrumentation for TanStack router with a new `tanstackRouterBrowserTracingIntegration` in the
`@sentry/react` SDK:
```javascript
import * as Sentry from '@​sentry/react';
import { createRouter } from '@​tanstack/react-router';
const router = createRouter({
// Your router options...
});
Sentry.init({
dsn: '___PUBLIC_DSN___',
integrations: [Sentry.tanstackRouterBrowserTracingIntegration(router)],
tracesSampleRate: 1.0,
});
```
##### Other Changes
- fix(nextjs): Do not hide `sourceMappingURL` comment on client when `nextConfig.productionBrowserSourceMaps: true` is
set ([#​12278](https://github.com/getsentry/sentry-javascript/issues/12278))
### [`v8.6.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#860)
##### Important Changes
- **feat(metrics): Add `timings` method to metrics ([#​12226](https://github.com/getsentry/sentry-javascript/issues/12226))**
This introduces a new method, `metrics.timing()`, which can be used in two ways:
1. With a numeric value, to simplify creating a distribution metric. This will default to `second` as unit:
```js
Sentry.metrics.timing('myMetric', 100);
```
2. With a callback, which will wrap the duration of the callback. This can accept a sync or async callback. It will
create an inactive span around the callback and at the end emit a metric with the duration of the span in seconds:
```js
const returnValue = Sentry.metrics.timing('myMetric', measureThisFunction);
```
- **feat(react): Add `Sentry.reactErrorHandler` ([#​12147](https://github.com/getsentry/sentry-javascript/issues/12147))**
This PR introduces `Sentry.reactErrorHandler`, which you can use in React 19 as follows:
```js
import * as Sentry from '@​sentry/react';
import { hydrateRoot } from 'react-dom/client';
ReactDOM.hydrateRoot(
document.getElementById('root'),
<React.StrictMode>
<App />
</React.StrictMode>,
{
onUncaughtError: Sentry.reactErrorHandler(),
onCaughtError: Sentry.reactErrorHandler((error, errorInfo) => {
// optional callback if users want custom config.
}),
},
);
```
For more details, take a look at [the PR](https://github.com/getsentry/sentry-javascript/pull/12147). Our
documentation will be updated soon!
##### Other Changes
- feat(sveltekit): Add request data to server-side events ([#​12254](https://github.com/getsentry/sentry-javascript/issues/12254))
- fix(core): Pass in cron monitor config correctly ([#​12248](https://github.com/getsentry/sentry-javascript/issues/12248))
- fix(nextjs): Don't capture suspense errors in server components ([#​12261](https://github.com/getsentry/sentry-javascript/issues/12261))
- fix(tracing): Ensure sent spans are limited to 1000 ([#​12252](https://github.com/getsentry/sentry-javascript/issues/12252))
- ref(core): Use versioned carrier on global object ([#​12206](https://github.com/getsentry/sentry-javascript/issues/12206))
### [`v8.5.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#850)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.4.0...8.5.0)
##### Important Changes
- **feat(react): Add React 19 to peer deps ([#​12207](https://github.com/getsentry/sentry-javascript/issues/12207))**
This release adds support for React 19 in the `@sentry/react` SDK package.
- **feat(node): Add `@sentry/node/preload` hook ([#​12213](https://github.com/getsentry/sentry-javascript/issues/12213))**
This release adds a new way to initialize `@sentry/node`, which allows you to use the SDK with performance
instrumentation even if you cannot call `Sentry.init()` at the very start of your app.
First, run the SDK like this:
```bash
node --require @​sentry/node/preload ./app.js
```
Now, you can initialize and import the rest of the SDK later or asynchronously:
```js
const express = require('express');
const Sentry = require('@​sentry/node');
const dsn = await getSentryDsn();
Sentry.init({ dsn });
```
For more details, head over to the
[PR Description of the new feature](https://github.com/getsentry/sentry-javascript/pull/12213). Our docs will be updated
soon with a new guide.
##### Other Changes
- feat(browser): Do not include metrics in base CDN bundle ([#​12230](https://github.com/getsentry/sentry-javascript/issues/12230))
- feat(core): Add `startNewTrace` API ([#​12138](https://github.com/getsentry/sentry-javascript/issues/12138))
- feat(core): Allow to pass custom scope to `captureFeedback()` ([#​12216](https://github.com/getsentry/sentry-javascript/issues/12216))
- feat(core): Only allow `SerializedSession` in session envelope items ([#​11979](https://github.com/getsentry/sentry-javascript/issues/11979))
- feat(nextjs): Use Vercel's `waitUntil` to defer freezing of Vercel Lambdas ([#​12133](https://github.com/getsentry/sentry-javascript/issues/12133))
- feat(node): Ensure manual OTEL setup works ([#​12214](https://github.com/getsentry/sentry-javascript/issues/12214))
- fix(aws-serverless): Avoid minifying `Module._resolveFilename` in Lambda layer bundle ([#​12232](https://github.com/getsentry/sentry-javascript/issues/12232))
- fix(aws-serverless): Ensure lambda layer uses default export from `ImportInTheMiddle` ([#​12233](https://github.com/getsentry/sentry-javascript/issues/12233))
- fix(browser): Improve browser extension error message check ([#​12146](https://github.com/getsentry/sentry-javascript/issues/12146))
- fix(browser): Remove optional chaining in INP code ([#​12196](https://github.com/getsentry/sentry-javascript/issues/12196))
- fix(nextjs): Don't report React postpone errors ([#​12194](https://github.com/getsentry/sentry-javascript/issues/12194))
- fix(nextjs): Use global scope for generic event filters ([#​12205](https://github.com/getsentry/sentry-javascript/issues/12205))
- fix(node): Add origin to redis span ([#​12201](https://github.com/getsentry/sentry-javascript/issues/12201))
- fix(node): Change import of `@prisma/instrumentation` to use default import ([#​12185](https://github.com/getsentry/sentry-javascript/issues/12185))
- fix(node): Only import `inspector` asynchronously ([#​12231](https://github.com/getsentry/sentry-javascript/issues/12231))
- fix(replay): Update matcher for hydration error detection to new React docs ([#​12209](https://github.com/getsentry/sentry-javascript/issues/12209))
- ref(profiling-node): Add warning when using non-LTS node ([#​12211](https://github.com/getsentry/sentry-javascript/issues/12211))
### [`v8.4.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#840)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.3.0...8.4.0)
##### Important Changes
- **feat(nextjs): Trace pageloads in App Router ([#​12157](https://github.com/getsentry/sentry-javascript/issues/12157))**
If you are using Next.js version `14.3.0-canary.64` or above, the Sentry Next.js SDK will now trace clientside pageloads
with React Server Components. This means, that client-side errors like
`Error: An error occurred in the Server Components render.`, which previously didn't give you much information on how
that error was caused, can now be traced back to a specific error in a server component.
- **feat(angular): Add Support for Angular 18 ([#​12183](https://github.com/getsentry/sentry-javascript/issues/12183))**
This release guarantees support for Angular 18 with `@sentry/angular`.
##### Other Changes
- feat(deps): Bump [@​opentelemetry/instrumentation-aws-lambda](https://github.com/opentelemetry/instrumentation-aws-lambda) from 0.41.0 to 0.41.1 ([#​12078](https://github.com/getsentry/sentry-javascript/issues/12078))
- fix(metrics): Ensure string values are interpreted for metrics ([#​12165](https://github.com/getsentry/sentry-javascript/issues/12165))
### [`v8.3.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#830)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.2.1...8.3.0)
##### Important Changes
- **Better Node Framework Span Data**
This release improves data quality of spans emitted by Express, Fastify, Connect, Koa, Nest.js and Hapi.
- feat(node): Ensure connect spans have better data ([#​12130](https://github.com/getsentry/sentry-javascript/issues/12130))
- feat(node): Ensure express spans have better data ([#​12107](https://github.com/getsentry/sentry-javascript/issues/12107))
- feat(node): Ensure fastify spans have better data ([#​12106](https://github.com/getsentry/sentry-javascript/issues/12106))
- feat(node): Ensure hapi spans have better data ([#​12140](https://github.com/getsentry/sentry-javascript/issues/12140))
- feat(node): Ensure koa spans have better data ([#​12108](https://github.com/getsentry/sentry-javascript/issues/12108))
- feat(node): Ensure Nest.js spans have better data ([#​12139](https://github.com/getsentry/sentry-javascript/issues/12139))
- feat(deps): Bump [@​opentelemetry/instrumentation-express](https://github.com/opentelemetry/instrumentation-express) from 0.38.0 to 0.39.0 ([#​12079](https://github.com/getsentry/sentry-javascript/issues/12079))
- **feat(node): No-code init via `--import=@​sentry/node/init` ([#​11999](https://github.com/getsentry/sentry-javascript/issues/11999))**
When using Sentry in ESM mode, you can now use Sentry without manually calling init like this:
```bash
SENTRY_DSN=https://examplePublicKey@o0.ingest.sentry.io/0 node --import=@​sentry/node/init app.mjs
```
When using CommonJS, you can do:
```bash
SENTRY_DSN=https://examplePublicKey@o0.ingest.sentry.io/0 node --require=@​sentry/node/init app.js
```
##### Other Changes
- chore: Align and update MIT license dates ([#​12143](https://github.com/getsentry/sentry-javascript/issues/12143))
- chore: Resolve or postpone a random assortment of TODOs ([#​11977](https://github.com/getsentry/sentry-javascript/issues/11977))
- doc(migration): Add entry for runWithAsyncContext ([#​12153](https://github.com/getsentry/sentry-javascript/issues/12153))
- docs: Add migration docs to point out that default import does not work ([#​12100](https://github.com/getsentry/sentry-javascript/issues/12100))
- docs(sveltekit): process.env.SENTRY_AUTH_TOKEN ([#​12118](https://github.com/getsentry/sentry-javascript/issues/12118))
- feat(browser): Ensure `browserProfilingIntegration` is published to CDN ([#​12158](https://github.com/getsentry/sentry-javascript/issues/12158))
- feat(google-cloud): Expose ESM build ([#​12149](https://github.com/getsentry/sentry-javascript/issues/12149))
- feat(nextjs): Ignore Prisma critical dependency warnings ([#​12144](https://github.com/getsentry/sentry-javascript/issues/12144))
- feat(node): Add app.free_memory info to events ([#​12150](https://github.com/getsentry/sentry-javascript/issues/12150))
- feat(node): Do not create GraphQL resolver spans by default ([#​12097](https://github.com/getsentry/sentry-javascript/issues/12097))
- feat(node): Use `node:` prefix for node built-ins ([#​11895](https://github.com/getsentry/sentry-javascript/issues/11895))
- feat(replay): Use unwrapped `setTimeout` to avoid e.g. angular change detection ([#​11924](https://github.com/getsentry/sentry-javascript/issues/11924))
- fix(core): Add dsn to span envelope header ([#​12096](https://github.com/getsentry/sentry-javascript/issues/12096))
- fix(feedback): Improve feedback border color in dark-mode, and prevent auto-dark mode when a theme is picked ([#​12126](https://github.com/getsentry/sentry-javascript/issues/12126))
- fix(feedback): Set optionOverrides to be optional in TS definition ([#​12125](https://github.com/getsentry/sentry-javascript/issues/12125))
- fix(nextjs): Don't put `undefined` values in props ([#​12131](https://github.com/getsentry/sentry-javascript/issues/12131))
- fix(nextjs): Fix legacy configuration method detection for emitting warning ([#​12136](https://github.com/getsentry/sentry-javascript/issues/12136))
- fix(node): Ensure fetch/http breadcrumbs are created correctly ([#​12137](https://github.com/getsentry/sentry-javascript/issues/12137))
- fix(node): Update `@prisma/instrumentation` from 5.13.0 to 5.14.0 ([#​12081](https://github.com/getsentry/sentry-javascript/issues/12081))
- ref(node): Add log for running in ESM/CommonJS mode ([#​12134](https://github.com/getsentry/sentry-javascript/issues/12134))
- ref(node): Handle failing hook registration gracefully ([#​12135](https://github.com/getsentry/sentry-javascript/issues/12135))
- ref(node): Only show instrumentation warning when tracing is enabled ([#​12141](https://github.com/getsentry/sentry-javascript/issues/12141))
Work in this release contributed by [@​pboling](https://github.com/pboling). Thank you for your contribution!
### [`v8.2.1`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#821)
[Compare Source](https://github.com/getsentry/sentry-javascript/compare/8.2…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an oversight in our Node
httpIntegration. It looks like we assumed that therequestobject being passed toignoreIncomingRequestHookandignoreOutgoingRequestHookwas of the same type. However, it's not:requestis of typeIncomingMessageinignoreIncomingRequestHookrequestis of typeRequestOptionsinignoreOutgoingRequestHookIn both cases though, we tried to obtain the url to pass into the
ignoreIncoming|outgoingRequestscallback via ourgetUrlhelper function. SinceIncomingMessagedoesn't have any of the properties required bygetUrl, we always passed///to theignoreIncomingRequestscallback.This PR fixes the bug by simply taking the
request.urlproperty instead and adds integration tests to properly test the two options.We could do more here, for example
makepass theignoreIncomingRequestHookfully/partially overwriteable like we did withrequestHookor via_experimentalConfigrequestobject as an additional param to the user-facing function but this should be done in a follow-up PR.fixes #12913