feat(node): Allow to pass registerEsmLoaderHooks to preload
#12998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Lms24
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
LGTM and agree on keeping the name aligned with the init option.
Users can then write their own custom preload script and configure this there, if wanted.
Sounds fair, given this won't be a widely used option. We should just make sure to document this because right now, we only show how to set integrations and debug via env variables.
timfish
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in here: #12912 (comment) there is no way today to exclude/include esm modules when preloading today.
This PR adds the option to pass
registerEsmLoaderHooksas option topreloadOpenTelemetry, which allows to exclude/include packages there as well. Users can then write their own custompreloadscript and configure this there, if wanted.Naming
I chose to use the same option naming here than for
init, although the semantics are a bit different - here we can't actually disable the wrapping (because that's the only reason to even call this). We can also use a different name if we want, but I thought this would maybe be easier to understand that this is the same thing 🤔