-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(browser): Initialize default integration if defaultIntegrations: undefined
#13261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Aug 7, 2024
mydea
approved these changes
Aug 7, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on E2E tests for TwP in meta frameworks, I noticed that we have erroneous logic in the browser SDK init code: If users or our higher-level SDKs pass
defaultIntegrations: undefined
to the Browser SDK's init options, it deactivates all default integrations. As per our docs, this should only happen if you explicitly passdefaultIntegrations: false
.This is caused by us spreading user-passed options over default SDK options, meaning previously set default options get overridden by users options being explicitly
undefined
instead of not set.This PR fixes this by removing the
defaultIntegrations
key from the user options object before merging the options together. Long-term, we need to fix this properly for all user-passed options. This is blocked on #13262