Skip to content

fix(opentelemetry): Do not overwrite http span name if kind is internal #13282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 8, 2024

If the kind of a http span is neither client nor server, it implies it is most likely being started with startSpan() manually, in which case we rather not want to overwrite the name.

@mydea mydea self-assigned this Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
@sentry/browser 22.47 KB (0%)
@sentry/browser (incl. Tracing) 34.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.65 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.71 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.33 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.17 KB (0%)
@sentry/browser (incl. metrics) 26.77 KB (0%)
@sentry/browser (incl. Feedback) 39.42 KB (0%)
@sentry/browser (incl. sendFeedback) 27.09 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.75 KB (0%)
@sentry/react 25.24 KB (0%)
@sentry/react (incl. Tracing) 37.25 KB (0%)
@sentry/vue 26.62 KB (0%)
@sentry/vue (incl. Tracing) 36.1 KB (0%)
@sentry/svelte 22.61 KB (0%)
CDN Bundle 23.69 KB (0%)
CDN Bundle (incl. Tracing) 35.94 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.62 KB (0%)
CDN Bundle - uncompressed 69.52 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.45 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.19 KB (0%)
@sentry/nextjs (client) 37.11 KB (0%)
@sentry/sveltekit (client) 34.82 KB (0%)
@sentry/node 115.51 KB (+0.04% 🔺)
@sentry/node - without tracing 89.91 KB (+0.06% 🔺)
@sentry/aws-serverless 99.34 KB (+0.04% 🔺)

@mydea mydea force-pushed the fn/node-infer-http branch from 08bcef6 to 1390457 Compare August 12, 2024 09:29
mydea added a commit that referenced this pull request Aug 12, 2024
…13305)

Noticed here: #13282
that we are not correctly setting origin for remix spans.
@mydea mydea force-pushed the fn/node-infer-http branch from 1390457 to 4b9bfa0 Compare August 12, 2024 10:47
@mydea mydea merged commit 51bbf32 into develop Aug 12, 2024
108 checks passed
@mydea mydea deleted the fn/node-infer-http branch August 12, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants