-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): Add bundleSizeOptimizations
to build options
#13323
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4fa73fd
feat(nextjs): Add `bundleSizeOptimizations` to build options
s1gr1d 5e920b8
Merge branch 'develop' into sig/next-bundler-optimization
s1gr1d 0723120
Merge branch 'develop' into sig/next-bundler-optimization
s1gr1d 013e1de
Merge branch 'develop' into sig/next-bundler-optimization
s1gr1d ee09a02
delete astro comment
s1gr1d ecef80c
Update packages/nextjs/src/config/types.ts
s1gr1d 27ce9fb
Merge branch 'refs/heads/develop' into sig/next-bundler-optimization
s1gr1d d927f72
create separate test
s1gr1d 653c341
delete from old test
s1gr1d ca3e691
Merge branch 'develop' into sig/next-bundler-optimization
s1gr1d 7b8e3de
Merge branch 'refs/heads/develop' into sig/next-bundler-optimization
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,10 @@ describe('getWebpackPluginOptions()', () => { | |
env: 'my-env', | ||
}, | ||
}, | ||
bundleSizeOptimizations: { | ||
excludeTracing: true, | ||
excludeReplayShadowDom: false, | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l: Any reason we added this here? I don't see any changes to assertions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, makes sense to separate this. I created another test just for those options. |
||
}); | ||
|
||
expect(generatedPluginOptions.authToken).toBe('my-auth-token'); | ||
|
@@ -105,6 +109,10 @@ describe('getWebpackPluginOptions()', () => { | |
}, | ||
telemetry: false, | ||
url: 'my-url', | ||
bundleSizeOptimizations: { | ||
excludeTracing: true, | ||
excludeReplayShadowDom: false, | ||
}, | ||
}); | ||
}); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks off (astro != nextjs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thanks, that's a copy paste error