Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Streamline some caching #13355

Merged
merged 2 commits into from
Aug 14, 2024
Merged

ci: Streamline some caching #13355

merged 2 commits into from
Aug 14, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 13, 2024

This streamlines some caching stuff for CI:

  1. Extract dependency installation & cache out into a composite action for reusability
  2. Updated the cache key for dependencies to only include package & dev-package package.json, not the E2E test ones.

@mydea mydea requested review from lforst and Lms24 August 13, 2024 14:19
@mydea mydea self-assigned this Aug 13, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.5 KB (0%)
@sentry/browser (incl. Tracing) 34.85 KB (0%)
@sentry/browser (incl. Tracing, Replay) 71.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 64.45 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.53 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 88.17 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90 KB (0%)
@sentry/browser (incl. metrics) 26.81 KB (0%)
@sentry/browser (incl. Feedback) 39.47 KB (0%)
@sentry/browser (incl. sendFeedback) 27.13 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.79 KB (0%)
@sentry/react 25.26 KB (0%)
@sentry/react (incl. Tracing) 37.83 KB (0%)
@sentry/vue 26.65 KB (0%)
@sentry/vue (incl. Tracing) 36.67 KB (0%)
@sentry/svelte 22.64 KB (0%)
CDN Bundle 23.73 KB (0%)
CDN Bundle (incl. Tracing) 36.49 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.81 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.06 KB (0%)
CDN Bundle - uncompressed 69.61 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 108.27 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.52 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 232.41 KB (0%)
@sentry/nextjs (client) 37.59 KB (0%)
@sentry/sveltekit (client) 35.45 KB (0%)
@sentry/node 115.61 KB (-0.1% 🔽)
@sentry/node - without tracing 90 KB (-0.12% 🔽)
@sentry/aws-serverless 99.42 KB (-0.1% 🔽)

@mydea mydea merged commit ecc299d into develop Aug 14, 2024
129 checks passed
@mydea mydea deleted the fn/cache-develop-only branch August 14, 2024 07:57
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this pull request Aug 26, 2024
This streamlines some caching stuff for CI:

1. Extract dependency installation & cache out into a composite action
for reusability
2. Updated the cache key for dependencies to only include package &
dev-package `package.json`, not the E2E test ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants