Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build: Bump node to 22.5.1" #13367

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

AbhiPrasad
Copy link
Member

Reverts #13118

There has been quite a bit of segmentation faults in CI after this PR was merged.

I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

@AbhiPrasad AbhiPrasad requested a review from a team August 14, 2024 01:38
@AbhiPrasad AbhiPrasad self-assigned this Aug 14, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and nicohrubec and removed request for a team August 14, 2024 01:38
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try Node 20 in the meantime?

@AbhiPrasad
Copy link
Member Author

Should we try Node 20 in the meantime?

Unfortunately that had even more segmentation faults :(

@AbhiPrasad AbhiPrasad merged commit fc319ea into develop Aug 14, 2024
127 checks passed
@AbhiPrasad AbhiPrasad deleted the revert-13118-abhi-node-22-local branch August 14, 2024 12:30
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this pull request Aug 26, 2024
Reverts getsentry#13118

There has been quite a bit of segmentation faults in CI after this PR
was merged.

I tried spending time to look into this in more detail, but it didn't
get far, so not worrying about this too much for now. Let's revert and
re-examine later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants