Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump Sentry bundler plugins #13384

Closed
wants to merge 7 commits into from
Closed

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 14, 2024

Includes a few fixes and stuff.

Fixes #13504

Copy link
Contributor

github-actions bot commented Aug 28, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.52 KB - -
@sentry/browser (incl. Tracing) 34.85 KB - -
@sentry/browser (incl. Tracing, Replay) 71.27 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 64.54 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.62 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.35 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.18 KB - -
@sentry/browser (incl. metrics) 26.83 KB - -
@sentry/browser (incl. Feedback) 39.59 KB - -
@sentry/browser (incl. sendFeedback) 27.18 KB - -
@sentry/browser (incl. FeedbackAsync) 31.9 KB - -
@sentry/react 25.28 KB - -
@sentry/react (incl. Tracing) 37.83 KB - -
@sentry/vue 26.66 KB - -
@sentry/vue (incl. Tracing) 36.68 KB - -
@sentry/svelte 22.65 KB - -
CDN Bundle 23.77 KB - -
CDN Bundle (incl. Tracing) 36.53 KB - -
CDN Bundle (incl. Tracing, Replay) 70.91 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.22 KB - -
CDN Bundle - uncompressed 69.61 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.28 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.8 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 232.99 KB - -
@sentry/nextjs (client) 37.6 KB - -
@sentry/sveltekit (client) 35.45 KB +0.02% +5 B 🔺
@sentry/node 115.75 KB -0.14% -157 B 🔽
@sentry/node - without tracing 89.88 KB -0.16% -141 B 🔽
@sentry/aws-serverless 99.29 KB -0.16% -159 B 🔽

View base workflow run

@mydea
Copy link
Member

mydea commented Aug 28, 2024

Question: Is there a reason to not use ^ version ranges for the bundler plugins? I feel like it has always to be safe to use a newer minor/patch version of the plugins, as we cannot have breaking changes there anyhow...?

ref #13504

@lforst
Copy link
Member Author

lforst commented Aug 28, 2024

Question: Is there a reason to not use ^ version ranges for the bundler plugins? I feel like it has always to be safe to use a newer minor/patch version of the plugins, as we cannot have breaking changes there anyhow...?

ref #13504

Anecdoally, I have found it better to have exact control over what versions are used.

@mydea
Copy link
Member

mydea commented Aug 28, 2024

Question: Is there a reason to not use ^ version ranges for the bundler plugins? I feel like it has always to be safe to use a newer minor/patch version of the plugins, as we cannot have breaking changes there anyhow...?
ref #13504

Anecdoally, I have found it better to have exact control over what versions are used.

We can think about revisiting this in the future - maybe it will safe us some time (no need to bump this all the time for fixes etc.). But it's totally fine right now, let's get this merged :D

@lforst
Copy link
Member Author

lforst commented Aug 28, 2024

let's get this merged :D

I would love to but this gives me the most cryptic CI errors that I have ever seen lolsob

@lforst lforst force-pushed the lforst-bump-bundler-plugins branch from 08a3e71 to 73f9172 Compare August 28, 2024 14:53
@lforst
Copy link
Member Author

lforst commented Aug 29, 2024

This PR is cursed. Burn in hell.

@lforst lforst closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete @sentry/webpack-plugin causes source maps being deleted before being uploaded
2 participants