ci: Always run build on develop branch #13404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Aug 16, 2024
Lms24
approved these changes
Aug 19, 2024
chargome
approved these changes
Aug 19, 2024
mydea
force-pushed
the
fn/always-run-develop
branch
from
2cb4d24 to
0be57c5
Compare
|
Hmm maybe I'm suffering from amnesia but why did we actually go through with this change? Skipping building and test on markdown-only PRs (like changelog) was a neat optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this here: https://github.com/getsentry/sentry-javascript/actions/runs/10417249817, when merging a markdown-only PR into develop, CI will not fully run there.