fix(node): ignore error rethrows in local variables integration #13480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
2 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The tests that are failing in CI are passing locally 🤦🏻♂️. It looks like in CI there are no variables attached to frames at all. |
|
Just thinking out loud because I ran into this again in my local as I was testing #13501 -- if the work we're doing in #13501 goes through, a really easy check is to see if the local vars were already captured on the error (either check LOCAL_VARIABLES_KEY or a separate boolean flag on the error object). If so -> skip doing the local vars again. Overall the new approach is a very nice simplification 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace #13418 because I couldn't push to that fork. Thanks to @Bruno-DaSilva
Closes #13416.
We ignore debugger call stacks in the worker that don't match the original error's call stack.