ci: Update actions/upload-artifact to v4 #13489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Aug 28, 2024
Lms24
approved these changes
Aug 28, 2024
mydea
force-pushed
the
fn/update-playwright-action
branch
from
63d431b
to
e9e44b4
Compare
mydea
commented
Aug 28, 2024
| uses: actions/upload-artifact@v3 | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| if: failure() |
There was a problem hiding this comment.
I adjusted this to only store these on failure, I think this is good enough? Then we do not have to store all the traces all the time when we do not need them.
There was a problem hiding this comment.
Traces should in general only be generated on failure - making this kinda moot - but we will save the ci time for the job running I guess.
There was a problem hiding this comment.
Jup, it seems to work, see here: https://github.com/getsentry/sentry-javascript/actions/runs/10593166442/attempts/1 there are two artifacts, for the two failed jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It keeps complaining that this is deprecated, so bumping this to v4.