-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Show what size limit jobs exceeded the limit #13532
Conversation
18cbad9
to
2330269
Compare
size-limit report 📦
|
3247805
to
b4cb6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like it a lot! Perhaps this is something we could also more clearly point out in the size-limit CI logs? There it's especially hard to find the entry that caused the job to fail. But maybe it's also just me who checks the logs rather than trusting the table 😅
I'll add a debug log in addition, too! 👍 |
b4cb6fd
to
5b05303
Compare
Noticed that it was a bit annoying, when we exceeded the size limit, to find out why/what has failed.
Now, it should show in the GH comment which specific check has failed, and what the current limit is:
While I was at this, I also streamlined the code a bit, extracted it a bit into utils to de-clutter stuff, and fixed/improved some debug logging issues (e.g. the log group was not correctly closed before, ...)