- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.7k
          feat(vercel-edge): Use opentelemetry for @sentry/vercel-edge
          #13742
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | size-limit report 📦
 | 
| ❌ 2 Tests Failed:
 View the top 2 failed tests by shortest run time
 
 To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard | 
@sentry/vercel-edge@sentry/vercel-edge
      b7aa759    to
    31bae24      
    Compare
  
    | sorry for the pings - managed to screw up a merge | 
              
                    chargome
  
              
              approved these changes
              
                  
                    Oct 7, 2024 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR is part of a stacked PR sequence as we need to do many changes at once for #8105. Merging this PR as is will create inconsistent data.
This PR will make the
@sentry/vercel-edgeSDK use OpenTelemetry performance under the hood.We need to employ a few hacks so that OpenTelemetry works on a worker runtime:
AsyncLocalStorageContextManagebecause the original implementation depends onAsyncLocalStorageas exported fromasync_hookswhich is not available in workers. In our vendored version we are taking it fromglobalThis.AsyncLocalStorage.performancewithDate.now()as that API is not available in worker runtimes.Resolves #13740