-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Add breadcrumbs for child_process
and worker_thread
#13896
feat(node): Add breadcrumbs for child_process
and worker_thread
#13896
Conversation
size-limit report 📦
|
Sorry for letting this one slip a bit. I have a concern with the value behind the individual things we log. Right now it seems we do:
If I put myself into the seat of a user that looks at an error in Sentry, I don't think I care to much when a worker/child is created. I mostly care about whether I receive some faulty messages from a worker (I don't think we can instrument this reliably), or whether a child/worker dies unexpectedly. What do you think about limiting the created breadcrumbs to error exits of children only? |
Both
Yep makes sense, I'll change this! |
Ah that's good to know. I still have concerns with how spammy this potentially gets so let's keep this in our head in case we want to instrument it in the future. Or maybe we can make it optional 🤔 |
We can also just add it later in another PR! I guess we already do something similar in |
I saw these were available in
diagnostics_channel
so this PR adds a default integration that includes breadcrumbs for both child process and worker thread start, stop and error.