fix(core): .set the sentry-trace header instead of .appending in fetch instrumentation
#13907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n fetch instrumentation
3 tasks
Contributor
size-limit report 📦
|
Lms24
approved these changes
Oct 8, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
I'm still curious how we'd attach headers multiple times but I think the change is fine.
I guess as long as we don't find out why this happene(d) testing against would be a bit artificial
added 2 commits
October 8, 2024 11:56
Contributor
Author
I think I know a way this can happen. Basically, if you re-use request objects. I'll try to come up with tests. |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
AbhiPrasad
approved these changes
Oct 9, 2024
billyvg
pushed a commit
that referenced
this pull request
Oct 17, 2024
…n fetch instrumentation (#13907)
billyvg
pushed a commit
that referenced
this pull request
Oct 17, 2024
…n fetch instrumentation (#13907)
3 tasks
This was referenced May 2, 2025
Lms24
added a commit
that referenced
this pull request
May 5, 2025
…ests (#16184) Analogously to #16183 for `fetch`, this patch ensures that manually set `sentry-trace` and `baggage` headers in XHR requests are respected by our XHR instrumentation and not overwritten. This patch also fixes a bug where we'd append multiple `sentry-trace` or `baggage` values in case the header was somehow set more than once (analogously to #13907 for `fetch`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13870
Fixes #12350
Fixes issues where persistence of the options object passed to
fetch()would cause the options object, or rather the attachedsentry-traceandbaggageheaders to indefinitely grow in size.