Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug(replay): Disregard replay duration for buffer mode #13923

Closed

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 9, 2024

This is not intended to be merged for now, I would like to debug how/why errors are occurring so far disconnected from the snapshot checkout times.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.74 KB +0.03% +6 B 🔺
@sentry/browser - with treeshaking flags 21.53 KB +0.03% +5 B 🔺
@sentry/browser (incl. Tracing) 35.01 KB +0.02% +6 B 🔺
@sentry/browser (incl. Tracing, Replay) 71.83 KB +0.22% +155 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.17 KB +0.16% +96 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.16 KB +0.2% +155 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.93 KB +0.18% +155 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.79 KB +0.17% +155 B 🔺
@sentry/browser (incl. metrics) 27 KB +0.03% +6 B 🔺
@sentry/browser (incl. Feedback) 39.88 KB +0.02% +8 B 🔺
@sentry/browser (incl. sendFeedback) 27.38 KB +0.03% +6 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.18 KB +0.03% +9 B 🔺
@sentry/react 25.5 KB +0.03% +7 B 🔺
@sentry/react (incl. Tracing) 37.98 KB +0.02% +7 B 🔺
@sentry/vue 26.91 KB +0.03% +7 B 🔺
@sentry/vue (incl. Tracing) 36.9 KB +0.02% +7 B 🔺
@sentry/svelte 22.87 KB +0.03% +7 B 🔺
CDN Bundle 24.12 KB +0.04% +8 B 🔺
CDN Bundle (incl. Tracing) 36.85 KB +0.02% +7 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.54 KB +0.1% +70 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.86 KB +0.1% +75 B 🔺
CDN Bundle - uncompressed 70.71 KB +0.02% +8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 109.37 KB +0.01% +8 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.05 KB +0.15% +339 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.27 KB +0.15% +339 B 🔺
@sentry/nextjs (client) 37.95 KB +0.02% +7 B 🔺
@sentry/sveltekit (client) 35.6 KB +0.02% +6 B 🔺
@sentry/node 124.91 KB +0.02% +13 B 🔺
@sentry/node - without tracing 94.14 KB +0.02% +19 B 🔺
@sentry/aws-serverless 103.71 KB +0.01% +8 B 🔺

View base workflow run

@billyvg billyvg force-pushed the debug-replay-disregard-replay-duration-for-buffer-mode branch from a8f60e0 to a8ad9a5 Compare October 9, 2024 17:30
@billyvg billyvg marked this pull request as ready for review October 9, 2024 18:32
@billyvg billyvg requested a review from a team as a code owner October 9, 2024 18:32

// XXX: disregard durations for buffer mode for debug purposes
if (this.recordingMode !== 'buffer') {
return;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only return (and not continue flushing) if in session mode and replay is too long or too short, otherwise setTag and continue flushing (for debugging purposes).

@billyvg billyvg force-pushed the debug-replay-disregard-replay-duration-for-buffer-mode branch from 2db7ad1 to 1da22e8 Compare October 10, 2024 21:42
@billyvg billyvg force-pushed the debug-replay-disregard-replay-duration-for-buffer-mode branch from 62cfc7d to 1ba0742 Compare October 11, 2024 12:54
@getsentry-bot getsentry-bot requested a review from a team as a code owner October 11, 2024 15:38
@billyvg billyvg closed this Oct 15, 2024
@billyvg billyvg deleted the debug-replay-disregard-replay-duration-for-buffer-mode branch October 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants